Closed Bug 13319 Opened 25 years ago Closed 24 years ago

Composite's on timers causing more repaints than needed

Categories

(Core :: Web Painting, defect, P3)

Product:
Core
Component:
Web Painting
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: pavlov, Assigned: kmcclusk)

Details

The view manager is causing an extra sync paint of toolbar buttons when you
mouse over them.  This seems to be coming from vm_timer_callback() which is a
timer created from SetFrameRate().  There is a comment in the timer code saying
mac doesn't need the repaint.  I have tried turning this repaint off on unix as
well, but that doesn't seem to make a difference.
Wait, you say the timer is causing an extra repaint, but if you comment it out,
the repaints dont go away ?  If so, then something else is causing the repaints.
Status: NEW → ASSIGNED
QA Contact: beppe → petersen
Target Milestone: M14
Would lowering the frame rate help? If so, this is done in layout itself.
Is this still a problem?
Severity: major → minor
Target Milestone: M14 → M16
Reassigning all view bugs to kevin.
Assignee: beard → kmcclusk
Status: ASSIGNED → NEW
I removed the timer code so vm_timer_callback() can never be called to force a 
repaint. The timer was unnecessary, so I ifdef'ed it out. I did not remove it 
because I may want to use it in the future for timer based flushing of 
invalidated regions. Currently, the widget holds the invalidated region so there 
is no point to flushing it. Flushing happens automatically when we return to the 
message pump.

Marking as Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking verified per last comments.
Status: RESOLVED → VERIFIED
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.