Closed Bug 133190 Opened 22 years ago Closed 22 years ago

UFS build problem with chimera

Categories

(SeaMonkey :: Build Config, defect, P2)

Product:
SeaMonkey
Component:
Build Config
Platform:
PowerPC
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: gus, Assigned: mikepinkerton)

Details

(Keywords: topembed, Whiteboard: [ADT1])

Attachments

(1 file)

fix case for UFS
857 bytes, patch
sdagley
: review+
bugzilla
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.9+)
Gecko/20020316
BuildID:    

I was compiling the cocoa stuff, and I came across this little compile bug-

On line 49 of nsMenuX.cpp is:

#include "nsMenubarX.h"

and it should be:

#include "nsMenuBarX.h"

With a capital 'B'.
I noticed this since I was compiling on a ufs disk-

Reproducible: Always
Steps to Reproduce:
1.Try to compile the mozilla cocoa stuff on a ufs disk.
2.
3.

Actual Results:  won't compile because of the case sensitivity.

Expected Results:  it shoulda compiled!
Sounds like the old building on UFS problem but I don't see nsMenBarX.h in the
Mozilla tree anywhere.  Chimera -> Hyatt.
Assignee: seawood → hyatt
Summary: Header include problem with nsMenuX.cpp → UFS build problem with chimera
nsMenuBarX.h is in widget/src/mac and widget/src/cocoa. both should probably be
fixed.
Assignee: hyatt → pinkerton
Status: UNCONFIRMED → NEW
Ever confirmed: true
we also have a <QuickDraw.h> in nsImageMac.h that should be fixed too.
needing r/sr
Status: NEW → ASSIGNED
Keywords: topembed
Priority: -- → P2
Target Milestone: --- → mozilla1.0
r=sdagley
Attachment #77031 - Flags: review+
Comment on attachment 77031 [details] [diff] [review]
fix case for UFS

sr=blake
Attachment #77031 - Flags: superreview+
Keywords: adt1.0.0
Whiteboard: [ADT1]
Comment on attachment 77031 [details] [diff] [review]
fix case for UFS

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77031 - Flags: approval+
landed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
QA to jj
QA Contact: granrose → jj
Adding + since this would have received one and I want to take this bug off the
adt1.0.0 radar.
Keywords: adt1.0.0 → adt1.0.0+
It looks like this was fixed on the branch already so adding fixed1.0.0
Keywords: fixed1.0.0
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: