1331966 - Autophone testAdobeFlash | application crashed [@ js::RunScript] after "Assertion failure: cx->compartment()->isSystem() || cx->runtime()->allowContentJS()"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Showed up on m-c after today's merge from inbound. We don't run the full set of Autophone tests on the integration branches (they're Tier 2 and resource-limited), so this went unnoticed previously. It's permafailing, however.

Bill, can you please take a look ASAP? I've CCed Bob Clary (maintainer of the Autophone tests) to this bug as well in case you need help reproducing.

https://treeherder.mozilla.org/logviewer.html#?job_id=69972506&repo=mozilla-central
https://treeherder.mozilla.org/logviewer.html#?job_id=69976719&repo=mozilla-central

Comment 1

[Intermittent Failures Robot]

31 failures in 165 pushes (0.188 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-central: 31

Platform breakdown:
* android-4-4-armv7-api15: 18
* android-4-2-armv7-api15: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-18&endday=2017-01-18&tree=all

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

I couldn't figure out a better way to fix this. Flash on Android calls into content JS during painting. Luckily we don't need this assertion on Android. So I just made it conditional on the platform.

Comment 3

[Intermittent Failures Robot]

19 failures in 143 pushes (0.133 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-central: 19

Platform breakdown:
* android-6-0-armv8-api15: 10
* android-4-4-armv7-api15: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-20&endday=2017-01-20&tree=all

Comment 4

[Intermittent Failures Robot]

91 failures in 690 pushes (0.132 failures/push) were associated with this bug in the last 7 days. 

This is the #9 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-central: 91

Platform breakdown:
* android-4-4-armv7-api15: 45
* android-6-0-armv8-api15: 23
* android-4-2-armv7-api15: 23

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-16&endday=2017-01-22&tree=all

Comment 5

[Intermittent Failures Robot]

49 failures in 127 pushes (0.386 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-central: 45
* mozilla-aurora: 4

Platform breakdown:
* android-4-4-armv7-api15: 17
* android-4-2-armv7-api15: 17
* android-6-0-armv8-api15: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-23&endday=2017-01-23&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84cc3465ba3e
Don't assert against content JS during painting on Android (r=dvander)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84cc3465ba3e

Comment 8

[Intermittent Failures Robot]

19 failures in 152 pushes (0.125 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-central: 12
* mozilla-aurora: 7

Platform breakdown:
* android-4-4-armv7-api15: 13
* android-6-0-armv8-api15: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-24&endday=2017-01-24&tree=all

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Thanks for the fix, Bill. Please request Aurora uplift on this when you get a chance.

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8828436 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]:bug 1328423
[User impact if declined]: Flash on Android might crash unexpectedly
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:no
[Why is the change risky/not risky?]:just removes an assertion
[String changes made/needed]:none

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8828436 [details] [diff] [review]
patch

Fixes an intermittent failure, Aurora53+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b123b9a23ce9

Comment 13

[Intermittent Failures Robot]

23 failures in 108 pushes (0.213 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-aurora: 20
* mozilla-central: 3

Platform breakdown:
* android-4-2-armv7-api15: 23

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-26&endday=2017-01-26&tree=all

Comment 14

[Intermittent Failures Robot]

110 failures in 749 pushes (0.147 failures/push) were associated with this bug in the last 7 days. 

This is the #12 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* mozilla-central: 69
* mozilla-aurora: 41

Platform breakdown:
* android-4-2-armv7-api15: 44
* android-4-4-armv7-api15: 42
* android-6-0-armv8-api15: 24

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1331966&startday=2017-01-23&endday=2017-01-29&tree=all