Closed
Bug 1331970
Opened 8 years ago
Closed 8 years ago
Crash in MenuPresentationAnimator
Categories
(Firefox for iOS :: General, defect, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.16
People
(Reporter: csuciu, Assigned: sleroux)
Details
(Keywords: crash, steps-wanted, topcrash, Whiteboard: [MobileCore])
Attachments
(2 files)
Currently #1 crash in Firefox 6.0 according to the Organizer.
|
||
Comment 1•8 years ago
|
||
Is this code only executed on opening the menu? iPhone 6 (iPhone7,2 in the report)?
|
|
||
Updated•8 years ago
|
Keywords: steps-wanted,
topcrash
|
Assignee | |
Comment 2•8 years ago
|
||
Crashing on L106 inside MenuPresentationAnimator.swift [1]:
> menuViewSnapshot = menuView.snapshotViewAfterScreenUpdates(false)!
We probably shouldn't be force unwrapping this. We do the same thing on L100 so we should fix that too. In this case, it will crash when dismissing the menu. Probably not easy to reproduce but you might be able to if you open the menu open/closed quickly or backgrounding the app and closing?
[1] https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Menu/MenuPresentationAnimator.swift#L106
|
|
Assignee | |
Updated•8 years ago
|
|
|
||
Comment 3•8 years ago
|
||
Dominating the top spot on 6.0 currently (affecting ~iPhone 99%).
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•8 years ago
|
Iteration: --- → 1.16
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8840972 -
Flags: review?(fpatel)
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [MobileCore] → [MobileCore][needsuplift]
|
||
Updated•8 years ago
|
Attachment #8840972 -
Flags: review?(fpatel) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
master b9b8f23c4d36b5840b142898843e37a4cf0fd933
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•8 years ago
|
||
v7.x 2bc4cb7a7e39d4f2bca36047dc4010802cbdd76f
status-fxios-v7.0:
--- → fixed
Whiteboard: [MobileCore][needsuplift] → [MobileCore]
You need to log in
before you can comment on or make changes to this bug.
Description
•