Closed Bug 1331986 Opened 3 years ago Closed 3 years ago

Set linux and android tasks previously in buildbot as tier 1

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(4 files)

We should set these tasks as tier 1
Comment on attachment 8827993 [details]
Bug 1331986 - Set linux and android test tasks previously in buildbot as tier 1.

https://reviewboard.mozilla.org/r/105548/#review106368

lots of platforms as tier-1, I cannot wait to get rid of this transform :)
Attachment #8827993 - Flags: review?(jmaher) → review+
Comment on attachment 8827994 [details]
Bug 1331986 - Set linux and android builds previously in buildbot as tier 1.

https://reviewboard.mozilla.org/r/105550/#review106370

::: taskcluster/ci/build/android.yml:61
(Diff revision 1)
>          job-name: android-x86-opt
>          type: nightly
>      treeherder:
>          platform: android-4-2-x86/opt
>          symbol: tc(N)
> -        tier: 2
> +        tier: 1

the default is tier 1 right?

https://dxr.mozilla.org/mozilla-central/rev/80eac484366ad881c6a10bf81e8d9b8f7a676c75/taskcluster/taskgraph/transforms/build.py#21

some platforms don't have a tier defined at all. for consistency, should we instead remove the `tier: 2` line everywhere in linux/android?
Comment on attachment 8827994 [details]
Bug 1331986 - Set linux and android builds previously in buildbot as tier 1.

https://reviewboard.mozilla.org/r/105550/#review106372
Attachment #8827994 - Flags: review?(jlund) → review+
Attached patch tier_diff.diffSplinter Review
As a sanity check, here is the diff of which tiers are what before/after.

Generated with the following:

$ hg up -r central
$ ./mach taskgraph full -p ./parameters-desktop-nightly.yml --json > ../jobs_test1.json 
$ hg up -r "children(children(.))"
$ ./mach taskgraph full -p ./parameters-desktop-nightly.yml --json > ../jobs_test2.json 

$ cat ../jobs_test1.json | jq '[. | to_entries[] | select(.key) | .value = .value.task.extra.treeherder.tier ] | from_entries' > ../jobs_before_tiers.json
$ cat ../jobs_test2.json | jq '[. | to_entries[] | select(.key) | .value = .value.task.extra.treeherder.tier ] | from_entries' > ../jobs_after_tiers.json
$ diff -U5 ../jobs_{before,after}_tiers.json > ../tier_diff.diff
Attachment #8828009 - Flags: feedback?(jmaher)
Attachment #8828009 - Flags: feedback?(jmaher) → feedback+
Comment on attachment 8828033 [details]
Bug 1331986 - Set more nightly stuff as tier 1 too.

https://reviewboard.mozilla.org/r/105556/#review106380

from irc:
<jlund> I suppose we want scriptworker tasks to be tier 1. but I wonder if this will annoy sheriffs? Do we close the tree if there is a failure?
18:16:15 
<aki> we're likely either going to have to set tier 2 on a number of things (l10n, cot) and monitor ourselves, or tier 1 and make things less fragile and more maintainable
18:16:30 the latter is better, but not sure if we're there yet. we can try and see what breaks
18:17:10 
<Callek> aki: the latter is what I set up just now with that latest patch, because of coops above "required for nightly"
18:17:16 
<aki> ok
18:17:17 
<Callek> but we can always roll it back a bit if we need
18:17:30 
<jlund> Jordan Lund okay, let's give it a whirl :)

::: taskcluster/ci/nightly-l10n/kind.yml:59
(Diff revision 1)
>           android-api-15-nightly: aws-provisioner-v1/gecko-{level}-b-android
>     treeherder:
>        symbol: tc-L10n(N)
>        tier:
>           by-build-platform:
> +            linux.*: 1

I didn't realize you could use regex expressions. neat.
Attachment #8828033 - Flags: review?(jlund) → review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/3eee272cff7f
Set linux and android test tasks previously in buildbot as tier 1. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/60168598b126
Set linux and android builds previously in buildbot as tier 1. r=jlund
https://hg.mozilla.org/mozilla-central/rev/a5253dce8b67
Set more nightly stuff as tier 1 too. r=jlund a=Kwierso
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.