Closed
Bug 1332005
Opened 7 years ago
Closed 7 years ago
Remove opaque BGRA8 image surface optimization
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
Details
Attachments
(1 file, 1 obsolete file)
|
5.82 KB,
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
With part 1 from bug 1311779, far fewer images start with the wrong surface format. According to the telemetry data, approximately 0.002% of images which are marked as opaque in imgFrame::Finish use the surface format B8G8R8A8 instead of B8G8R8X8 and thus are able to take advantage of this optimization (see https://mzl.la/2iByJWT). We should be able to remove this and simplify the code.
|
Assignee | |
Comment 1•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce7685fd95de43a85a570bb253bb978d1996ab9c
|
|
Assignee | |
Comment 2•7 years ago
|
||
Was hasty, mHasNoAlpha is not used anymore either.
Attachment #8828024 -
Attachment is obsolete: true
Attachment #8828024 -
Flags: review?(tnikkel)
Attachment #8828038 -
Flags: review?(tnikkel)
|
||
Updated•7 years ago
|
Attachment #8828038 -
Flags: review?(tnikkel) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9e64504f9a Remove opaque BGRA8 image surface optimization. r=tnikkel
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0f9e64504f9a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•