Closed Bug 1332005 Opened 3 years ago Closed 3 years ago

Remove opaque BGRA8 image surface optimization

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file, 1 obsolete file)

With part 1 from bug 1311779, far fewer images start with the wrong surface format. According to the telemetry data, approximately 0.002% of images which are marked as opaque in imgFrame::Finish use the surface format B8G8R8A8 instead of B8G8R8X8 and thus are able to take advantage of this optimization (see https://mzl.la/2iByJWT). We should be able to remove this and simplify the code.
Was hasty, mHasNoAlpha is not used anymore either.
Attachment #8828024 - Attachment is obsolete: true
Attachment #8828024 - Flags: review?(tnikkel)
Attachment #8828038 - Flags: review?(tnikkel)
Attachment #8828038 - Flags: review?(tnikkel) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9e64504f9a
Remove opaque BGRA8 image surface optimization. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/0f9e64504f9a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.