Convert MOZ_ASSERT(!IsShutdown()) to MOZ_DIAGNOSTIC_ASSERT(!IsShutdown()) in MediaDecoder.h

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1319790 has done that in MediaDecoder.cpp. We also need it for MediaDecoder.h to debug the crash.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Priority: -- → P3
See Also: → bug 1319790
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8828196 [details]
Bug 1332146 - use stronger assertions in MediaDecoder.h

https://reviewboard.mozilla.org/r/105666/#review106546
Attachment #8828196 - Flags: review?(kaku) → review+
(Assignee)

Comment 3

2 years ago
Thanks!

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cb11189cd2d2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.