133217 - [regression] Delay in onmouseover is back

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Markus Hübner]

The bug 108161 is back - example to test, left menu-items:
http://www.medianet.at/
with build 2002032203 on win-xp,1.1ghz,327ram
when moving over the menu-items on the left the old behaviour (delay) is back.
The page works fine in 0.9.9

Comment 1

[Brendan Eich [:brendan]]

How about cc'ing the crucial people (reviewers, etc.) from bug 108161, eh?  An
empty cc: list is no good.

/be

Comment 2

[Markus Hübner]

Further investigations showed that the regression started in build 2002030803.
The build 2002030703 is fine.

Comment 3

[Kevin McCluskey (gone)]

WFM: Using 2002032603 build on WinNT running on 433Mhz Intel. Performance on
mouse over is good.

Comment 4

[Kevin McCluskey (gone)]

embed triage: topembed-

Comment 5

[Markus Hübner]

using build 2002032603 on win-xp,1.1ghz,327ram the considerable delay is still 
there at http://www.medianet.at !

Comment 6

[Asa Dotzler [:asa]]

worksforme with 032708 mozilla build on win2K. As fast as IE6 for me.

Comment 7

[Markus Hübner]

Using build 2002032708 on win2k, amd athlon, 256ram there is a considerable 
delay! Another URL would be http://www.tagesschau.de the menu-items on the left 
(fernsehen, hörfunk, ...).

Comment 8

[Eugene Savitsky]

I also see moz slower than IE, but not critical, ~20%.

moz 2002032603, duron 950

Comment 9

[Markus Hübner]

It seems that the problem on http://www.medianet.at is due to bug 86319.
But I don't have a clue what is causing the dealy on http://www.tagesschau.de

Comment 10

[Matthias Versen [:Matti]]

I see a problem with www.tagesschau.de and the Main Menu Entrys.
(not the Menu Entrys in the sub Menu)

Mozilla requests the image every time if you move the mouse over an entry and
don't use the cached image. 
My Cache-Setting: Automatic.

I nominate it again, this sucks for all people with a slow connection.

Comment 11

[Matthias Versen [:Matti]]

Attachment: Packet Tracve for a Mouse over (it's the third time i moved my mouse over that menu entry)

Comment 12

[saari (gone)]

nsbeta1+ [adt2 RTM] because I think we REALLY need to fix this for RTM. It isn't
offically blocking any embeddors so topembed-, for now at least, but again, we
really want it, so marked embed.

Comment 13

[Ere Maijala (slow)]

There might be something affecting this in bug 138791.

Comment 14

[Itamar]

Because of comment 11 - isn't this a dup of bug 93461
It seems that the images are not cached but requested again and again from the
network.

Comment 15

[Itamar]

Hi,
Well I don't mean to spam but I don't see that now.
The only thing that changed is a problem with my network connection that I
solved 5 minutes ago.
The common thing about both http://www.medianet.at/ and http://www.hp.com is
that it took them over 1 minute to load when I had the network problem.
My new thought is that maybe what you see is this:
When mozilla loads the page it tries to load all the images - because of
problems with the connection it loads them ok but never "thinks" that its done
downloading the images, so every mouseover it retries to download the images and
fails again and again...
Now that the sites load smoothly I don't see the problem anymore.
What do you think?

Comment 16

[Stuart Parmenter]

Attachment: Use the correct prescontext from the html code

since imagelib uses the context value to compare between images from the same
document, we need to pass in the same prescontext pointer as we do in layout

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 81566 [details] [diff] [review]
Use the correct prescontext from the html code

r=biesi

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 81566 [details] [diff] [review]
Use the correct prescontext from the html code

sr=[e-mail]

Comment 19

[Stuart Parmenter]

even with this patch, mouseovers do seem a *tiny* bit slower (it may just be my
mind).  on the plus side, this patch will fix a fair number of the bugs related
to images getting fetched from the server twice.

Comment 20

[Stuart Parmenter]

ok, this patch ends up only being a cleanup and doesn't effect anything since 
QI of a nsIPresContext to nsISupports doesn't change anything since

Comment 21

[Stuart Parmenter]

Ok, this bug has nothing to do with the previous bug.  Images are *not* being 
reloaded from the network more than once.  I see no regression between 0.9.9 
and the trunk.

Comment 22

[Markus Hübner]

Reopening. The bug description doesn't say anything about images being 
reloaded from the network more than once. Testing trunk build 2002042 (win-
xp,1.1ghz,512ram) on http://www.medianet.at for example, the noticeable delay 
is still there. As mentioned this worked perfectly in 0.9.9

Comment 23

[Alexander Munk]

Using build 2002042908 on win2k I also see this annoying delay.
Although all pictures are loaded I get "Transferring data from 
www.medianet.at ..."  It's probably that what is causing the delay.

Comment 24

[Markus Hübner]

Could this be related to bug 102321 ?

Comment 25

[dcone (gone)]

Do you have a gforce II card...
If you do.. try 1.) Updating the gforce drivers.
                2.) turning off the optimization for the drivers.

Its seems from all the reports.. that some gforce cards are having a hard time
with the bit blits..

Comment 26

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 81566 [details] [diff] [review]
Use the correct prescontext from the html code

Approval noted in bug for branch checking; please make sure it's in the trunk
as well

Comment 27

[Markus Hübner]

Using trunk build 2002050104 nothing changed.
The delay is there - testing workstations with 4 different video cards.

Comment 28

[dcone (gone)]

this may be related to 
http://bugzilla.mozilla.org/show_bug.cgi?id=102321
when that gets checked in..  I bet this goes away, or at least part of the 
slowness.

Comment 29

[Markus Hübner]

Yeah - this one got fixed. using 2002050208 :))
Nice work dcone & saari!

Comment 30

[Terri Preston]

Verified fixed win 2k build 2002052809

Comment 31

[scottputterman]

adding adt1.0.1-.  Let's get this in the next release.