1332191 - Move CrossProcessSafeEvent() in EventStateManager.cpp to WidgetEvent class

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

This is one of preparation of bug 1257617.

The static method CrossProcessSafeEvent() in EventStateManager.cpp should be a class method of WidgetEvent.  Then, it can be available everywhere.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b881f1c3cde7

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Bug 1332191 Move CrossProcessSafeEvent() in EventStateManager.cpp to WidgetEvent::CanBeSentToRemoteProcess()

It doesn't make sense to check this in a static method of EventStateManager.cpp.  Instead, it should be a class method of WidgetEvent.  Then, everybody can check this in everywhere.

This patch adds mFlags.mNoCrossProcessBoundaryForwarding because when it's true, any events shouldn't be sent to remote process.

Review commit: https://reviewboard.mozilla.org/r/105798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105798/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8828348 [details]
Bug 1332191 Move CrossProcessSafeEvent() in EventStateManager.cpp to WidgetEvent::CanBeSentToRemoteProcess()

https://reviewboard.mozilla.org/r/105798/#review106806

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdc55c839eb3
Move CrossProcessSafeEvent() in EventStateManager.cpp to WidgetEvent::CanBeSentToRemoteProcess() r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bdc55c839eb3