|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Spotted while building with gcc 6: 8:40.55 /home/sewardj/MOZ/MC-TALL/media/libstagefright/binding/H264.cpp:734:23: warning: comparison is always true due to limited range of data type [-Wtype-limits] 8:40.55 NS_ASSERTION(numPps <= MAX_PPS_COUNT, "Exceed the maximum PPS counts!"); numPps is a uint8_t, and MAX_PPS_COUNT is 256. I'm not sure what was intended here.
Alastor, you introduced this in bug 1321164. Should be easy to fix using jya's READUE macro from bug 1322961.
Sorry, didn't notice this error. Since we read 8 bits from extradata, the value would never exceed MAX_SPS/PPS_COUNT (256). I want to directly remove these assertions. BTW, the bug 1322961 is used for BitReader, not ByteReader.
Comment on attachment 8828260 [details] Bug 1332199 - remove always-true assertion. https://reviewboard.mozilla.org/r/105732/#review106618 Even simpler than I thought! Thank you for taking care of this so quickly.