1332227 - Add options for Hide Images that allows the user to select when images should be displayed

Status: RESOLVED WONTFIX

(Firefox for iOS :: General, enhancement, P3)

Description

[Simon Basca [:SimonB]]

Consider adding options for Hide Images similar on Android, in the Settings menu that allows the user to select when images should be displayed depending on network bearer:

- Always show all images
- Over Wi-Fi only
- Always blocked

See Android bug that implemented this: -> ttps://bugzilla.mozilla.org/show_bug.cgi?id=1170725

Comment 1

[lyang]

If adding options for hide images in the setting menu, Should we remove 'Hide Images' button in the toolbar menu?

Comment 2

[lyang]

I hope the browser can provide an extra option to users that they can choose to display this feature or not in toolbar menu.
Because in China, the data for mobile is limited, users are always to save their data charges with no image mode. I think it is a frequently used feature for some people, so it will be more convenient for them in toolbar menu. The most commonly user case is turn on the feature in 3G/4G, and turn off in WiFi. There is another reason that most of local browsers in China put the feature on toolbar menu.

Comment 3

[Stephan Leroux [:sleroux]]

> I hope the browser can provide an extra option to users that they can choose to display this feature or not in toolbar menu.

I believe we already have this feature in the toolbar menu but is disabled behind a feature flag [1]. IIRC the reason it's not enabled in release is that there were some web compatibility issues with how the feature is implemented in JS (:AaronMT?). I agree that this would be a great feature users who are looking for a low bandwidth way of using Firefox. 

Another part of this story is how we expose various options in the menu. I can see certain options more useful for some people than others and having many pages of actions will make it cumbersome for some users to use features they use often. I don't know if we're at that point yet so I digress.

[1] https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Menu/AppMenuConfiguration.swift#L124

Comment 4

[Aaron Train [:aaronmt]]

I would advocate placing the toggle on the second page of the menu, or in advanced settings and on activation, issue a warning to the user. My $0.02.

However, it hasn't been tested enough to discover any major site issues. The site compatibility issues we filed were related to the 'night mode' on Nightly.

Comment 5

[lyang]

I used another way to implement night mode. Now the site compatibility issues related the 'night mode' has not existed. Do you have any plan to rlease 'night mode'?

Comment 6

[Aaron Train [:aaronmt]]

That's a product decision

Comment 7

[lyang]

Attachment: proposal

According to compare with other products in china, I have two plans about this feature. What do you think?

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Thank you very much for this proposal. Let's talk about this next time we meet.

Comment 9

[lyang]

Attachment: pull request

Add options for Hide Images that allows the user to select when images should be displayed