1332233 - [Static Analysis][Resource leak] In function CustomElementRegistry::Define

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a resource leak can happen in the following context:

>>   CustomElementDefinition* definition =
>>     new CustomElementDefinition(nameAtom,
>>                                 localNameAtom,
>>                                 constructor,
>>                                 constructorPrototype,
>>                                 callbacks,
>>                                 0 /* TODO dependent on HTML imports. Bug 877072 */);
>> 
>>   /**
>>    * 12. Add definition to this CustomElementRegistry.
>>    */
>>   if (!mConstructors.put(constructorUnwrapped, nameAtom)) {
>>     aRv.Throw(NS_ERROR_FAILURE);
>>     return;
>>   }

I think we should allocate definition after the if statement.

Comment 1

[Andi [:andi]]

Attachment: Bug 1332233 - prevent resource leak in CustomElementRegistry::Define.

Review commit: https://reviewboard.mozilla.org/r/105764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105764/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8828303 [details]
Bug 1332233 - prevent resource leak in CustomElementRegistry::Define.

https://reviewboard.mozilla.org/r/105764/#review106654

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/335c864df46d
prevent resource leak in CustomElementRegistry::Define. r=baku

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/335c864df46d