Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[RTL] Faded text sometimes becomes blank after scrolling

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: maliu, Assigned: maliu)

Tracking

(Blocks: 1 bug, {rtl})

Trunk
Firefox 53
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
STR:

1. Open many tabs mixed with LTR and RTL titled web page.
2. Open History tab in Home page.
3. Scroll up/down.

AR:
  Some rows are blank when sometimes title appear back on.

Comment 1

6 months ago
attachment 8827524 [details] - Before scrolling
attachment 8827525 [details] - After scrolling

Thanks for opening this bug for me, Max :)
Comment hidden (mozreview-request)

Comment 3

6 months ago
mozreview-review
Comment on attachment 8828390 [details]
Bug 1332258 - Reset text fading gradient to null when text direction changed,

https://reviewboard.mozilla.org/r/105818/#review106742

::: mobile/android/base/java/org/mozilla/gecko/widget/FadedSingleColorTextView.java:55
(Diff revision 1)
> +        final boolean isTextDirectionRtl = mIsTextDirectionRtl;
> +        if (!TextUtils.isEmpty(text)) {
> -        mIsTextDirectionRtl = BidiFormatter.getInstance().isRtl((String) text);
> +            mIsTextDirectionRtl = BidiFormatter.getInstance().isRtl((String) text);
> -        if (mIsTextDirectionRtl) {
> -            setTextDirection(TEXT_DIRECTION_RTL);
>          }
> +        if (mIsTextDirectionRtl != isTextDirectionRtl) {
> +            mTextGradient = null;

It's a bit confusing that isTextDirectionRtl and  mIsTextDirectionRtl is basically the same name. Maybe the code is easier to follow if it's named currentTextDirectionRtl or previousTextDirectionRtl?
Attachment #8828390 - Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 5

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e4d9a133fb58
Reset text fading gradient to null when text direction changed, r=sebastian
Keywords: checkin-needed
Blocks: 1319302
https://hg.mozilla.org/mozilla-central/rev/e4d9a133fb58
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 7

6 months ago
I can confirm this is fixed on latest Nightly.
You need to log in before you can comment on or make changes to this bug.