Closed Bug 1332267 Opened 3 years ago Closed 3 years ago

The "host" and "hostless" class names are too generic

Categories

(Firefox :: Site Identity, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

The identity panel shares the browser.xul document with many other UI pieces, so it needs to use class names that are distinctive enough to not be targeted accidentally by CSS or JS code using generic class names.
Comment on attachment 8828309 [details]
Bug 1332267 - Rename the "host" and "hostless" classes to be more distinctive.

https://reviewboard.mozilla.org/r/105776/#review106662

LGTM thanks
Attachment #8828309 - Flags: review?(jkt) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b07a797b00e5
Rename the "host" and "hostless" classes to be more distinctive. r=jkt
https://hg.mozilla.org/mozilla-central/rev/b07a797b00e5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
I have reproduced this on Firefox nightly according to (2017-02-26)

Fixing bug is verified on Latest Developer Edition -- Build ID:(20170303004003), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:53.0) Gecko/20100101 Firefox/53.0

Tested OS-- Windows10 32bit
[bugday-20170308]
You need to log in before you can comment on or make changes to this bug.