Closed Bug 1332312 Opened 4 years ago Closed 4 years ago

remove JS_DISABLE_SLOW_SCRIPT_SIGNALS

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

This environment variable was initially useful because the old implementation of the slow-script interrupt would trigger random segfaults when touching Ion code and this would frequently bother devs.  Mach also started setting this by default because it's usually what you'd want.

However, the implementation of the async interrupt was changed and now the only use of segfaults is to handle asm.js/wasm out-of-bounds which isn't a normal occurrence (even when debugging wasm).  Moreover, disabling signals now entirely disables wasm/asm.js, so the option is now just a source of confusion.

This patch removes all references to JS_DISABLE_SLOW_SCRIPT_SIGNALS.
Attachment #8828355 - Flags: review?(bbouvier)
Comment on attachment 8828355 [details] [diff] [review]
rm-disable-slow-script-signals

Review of attachment 8828355 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed, thanks for the patch.
Attachment #8828355 - Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6a32514517
remove JS_DISABLE_SLOW_SCRIPT_SIGNALS (r=bbouvier)
https://hg.mozilla.org/mozilla-central/rev/dc6a32514517
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.