pressing "Ship It" when previous review was review- marks the revised patch review-

RESOLVED INVALID

Status

MozReview
General
RESOLVED INVALID
a year ago
a year ago

People

(Reporter: dbaron, Unassigned)

Tracking

Details

In bug 1331846 I reviewed a revised patch and pressed the "Ship It" button.  Doing so gave me a confirmation dialog, and then marked the patch as review- instead of review plus (bug 1331846 comment 8).  The state in MozReview itself also indicated that the patch had not been reviewed.

I would have expected pressing the "Ship It" button (which I don't use much) would have marked the patch as review+.
Summary: pressing "Ship It" when previous review was review- marks the new patch review- → pressing "Ship It" when previous review was review- marks the revised patch review-
Invalid for the same reason as bug 1332763.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.