Open Bug 1332352 Opened 3 years ago Updated 2 years ago

Last test seen not part of gtest timeout message

Categories

(Testing :: GTest, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: gbrown, Unassigned)

References

Details

As seen in bug 1115253, when a gtest times out, the currently running test ("last test seen") is not reported, so all timeouts are reported with the same message and end up in the same bug. It would be easier to deal with specific issues in specific bugs based on a more precise error message:

TEST-UNEXPECTED-FAIL | <last test seen> | timed out after 1200 seconds
The gtest Python harness doesn't do much here, it currently just sends the output from the C++ binary to stdout:
https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/testing/gtest/rungtests.py#52

and then uses unstructured logging to log things like the timeout failure:
https://dxr.mozilla.org/mozilla-central/rev/96cb95af530477edb66ae48d98c18533476e57bb/testing/gtest/rungtests.py#70

The formatter for the results of the C++ tests lives here:
https://dxr.mozilla.org/mozilla-central/source/testing/gtest/mozilla/GTestRunner.cpp

Other harnesses look at structured log messages nowadays for the last-run-test. We could just scrape the TEST-START messages as a simple hack, and maybe make the C++ harness output structured logs at some point in the future.
: Ted Mielczarek, :Geoff Brown

Do you guys have any update on this issue? Because it is blocking Bug 1115253.
Flags: needinfo?(ted)
Flags: needinfo?(gbrown)
I think that resolving this bug is a good idea, but I don't have time for it and I'm not sure who else might be able to look at it. While this bug would help diagnose bug 1115253, it doesn't really block it.
No longer blocks: 1115253
Flags: needinfo?(gbrown)
See Also: → 1115253
Component: General → GTest
I do not.
Flags: needinfo?(ted)
You need to log in before you can comment on or make changes to this bug.