1332394 - add BUG_COMPONENT to hal/* files

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

currently we do not have any referenced bug components section in a moz.build for for the hal/* files.

there are:
hal/*.cpp|*.h
hal/android/
hal/cocoa/
hal/fallback/
hal/gonk/
hal/linux/
hal/sandbox/
hal/windows/

Should all of the files in this tree belong to core::HAL?
Do we need hal/gonk/* ?
There is no triage point of contact https://bugzilla.mozilla.org/page.cgi?id=triage_owners.html, we should find one?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to hal/*

with this patch, I can now do:
$ ./mach file-info bugzilla-component hal/**
Core :: Hardware Abstraction Layer (HAL)
  hal/Hal.cpp
  hal/Hal.h
  hal/HalImpl.h
  hal/HalInternal.h
  hal/HalLog.h
  hal/HalSandbox.h
  hal/HalScreenConfiguration.h
  hal/HalSensor.h
  hal/HalTypes.h
  hal/HalWakeLock.cpp
  hal/HalWakeLock.h
  hal/WindowIdentifier.cpp
  hal/WindowIdentifier.h
  hal/android
  hal/cocoa
  hal/fallback
  hal/gonk
  hal/linux
  hal/moz.build
  hal/sandbox
  hal/windows


it would be nice to adjust things as needed and to get a triage owner for hal :)

Comment 2

[Andrew Overholt [:overholt]]

I'm not sure who'd be best to triage this component. Let me think about it (keeping r? for now).

Comment 3

[Andrew Overholt [:overholt]]

I think Dave or Gabriele should be the owner here.

Comment 4

[Andrew Overholt [:overholt]]

Comment on attachment 8828440 [details] [diff] [review]
add BUG_COMPONENT to hal/*

Review of attachment 8828440 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I didn't realize what you were going for here. Looks good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8818cff58662
add BUG_COMPONENT to hal/* files. r=overholt

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8818cff58662

Comment 7

[Dave Hylands [:dhylands]]

Looks like this got addressed.