1332411 - Enable print_via_parent for Tier3 platforms

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Jan Beich]

XP_WIN + XP_MACOSX + XP_LINUX covers everything Tier1 atm. What's left are Darwin/X11, BSDs, Solaris using Gtk and iOS, the support for which is going to bitrot over time the farther they stray away from any of Tier1 platform.

Comment 1

[Jan Beich]

Attachment: Bug 1332411 - Enable print_via_parent for Tier3 platforms.

Review commit: https://reviewboard.mozilla.org/r/105862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105862/

Comment 2

[Lee Salzman [:lsalzman]]

On said platforms, are they using our Fontconfig platform font list that is bound up with our GTK support? If so, then they are supported, and it's just a matter of flipping the pref. The only case that does not currently work is if using the gfxFT2FontList (currently only Android that I know of) does not have NativeFontResource implemented for it yet, so only that wouldn't work.

If said platforms are GTK then basically all we have to do is change this line:
https://dxr.mozilla.org/mozilla-central/source/modules/libpref/init/all.js?q=all.js%3A1112&redirect_type=direct#1112

Currently it is predicated on XP_LINUX, but that could thus be changed to MOZ_WIDGET_GTK, and we'd thus be done.

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

We don't implement print_via_parent for all platforms yet, so we can't just blindly remove all the checking for setting the pref default. Correct way to do this for now would probably be checking for MOZ_WIDGET_GTK as suggested.

Comment 4

[Jan Beich]

(In reply to Lee Salzman [:lsalzman] from comment #2)
> On said platforms, are they using our Fontconfig platform font list that is
> bound up with our GTK support?

Do you mean "monospace", "serif", "sans-serif" ? I don't think Firefox supports Gtk *without* fontconfig.

> The only case that does not currently work is if using the
> gfxFT2FontList (currently only Android that I know of) does not have
> NativeFontResource implemented for it yet, so only that wouldn't
> work.

Android defines XP_LINUX, so I'm not sure what you mean here.

Comment 5

[Lee Salzman [:lsalzman]]

(In reply to Jan Beich from comment #4)
> (In reply to Lee Salzman [:lsalzman] from comment #2)
> > On said platforms, are they using our Fontconfig platform font list that is
> > bound up with our GTK support?
> 
> Do you mean "monospace", "serif", "sans-serif" ? I don't think Firefox
> supports Gtk *without* fontconfig.
> 
> > The only case that does not currently work is if using the
> > gfxFT2FontList (currently only Android that I know of) does not have
> > NativeFontResource implemented for it yet, so only that wouldn't
> > work.
> 
> Android defines XP_LINUX, so I'm not sure what you mean here.

Then that would be an unfortunate accident. Since it does not actually work at all on Android, and by virtue of the fact we don't enable E10s there yet we avoided catastrophe for now.

Comment 6

[Jan Beich]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105862/diff/1-2/

Comment 7

[Jan Beich]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105862/diff/2-3/

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

https://reviewboard.mozilla.org/r/105862/#review110680

If Lee is OK with this I have no objection.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a28293f9d514
Enable print_via_parent for Tier3 platforms. r=ted

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a28293f9d514

Comment 11

[Jan Beich]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1309205 regression on Android and feature parity with Linux on BSDs
[User impact if declined]: Printing to file on FreeBSD may fail with e10s enabled
[Is this code covered by automated tests?]: Unlikely
[Has the fix been verified in Nightly?]: Yes, by myself.
[Needs manual test from QE? If yes, steps to reproduce]: Probably not.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: For Tier1 only restores Android behavior to before bug 1309205 per comment 5.
[String changes made/needed]: None

Comment 12

[Gerry Chang [:gchang]]

Comment on attachment 8828469 [details]
Bug 1332411 - Enable print_via_parent for Tier3 platforms.

Fix a potential printing issue on FreeBSD. Aurora53+.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/834d02e98a74