JS Console icons misnamed in Classic theme.

RESOLVED FIXED

Status

SeaMonkey
Themes
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: John Dobbins, Assigned: Adam Becevello)

Tracking

({fixed1.4.1})

Trunk
fixed1.4.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
Build 2002032408

mozilla/ themes/ classic/ global/ win/ console.css  and
mozilla/ themes/ classic/ global/ mac/ console.css 

line 67 reads
   background: url("chrome://global/skin/console/error-dash.gif") repeat-x top;

line 72 reads
   background: url("chrome://global/skin/console/error-caret.gif") no-repeat top;

the icons in mozilla/ themes/ classic/ global/ console
are named console-error-dash.gif and console-error-caret.gif

The icons should be named error-dash.gif and error-caret.gif so they match the
icons in the modern theme and the URLs in the Classic CSS.

Updated

16 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

15 years ago
Created attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console
(Assignee)

Comment 2

15 years ago
Comment on attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console

Requesting review of this patch to restore the little green arrows in the
javascript console in classic theme.  The filenames were incorrect.
Attachment #123466 - Flags: review?(hewitt)
(Assignee)

Updated

15 years ago
Attachment #123466 - Flags: review?(hewitt) → review?(bryner)
Summary: Java Console icons misnamed in Classic theme. → JS Console icons misnamed in Classic theme.
Attachment #123466 - Flags: review?(bryner) → review+
(Assignee)

Updated

15 years ago
Attachment #123466 - Flags: superreview?(alecf)

Comment 3

15 years ago
Comment on attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console

sr=alecf
Attachment #123466 - Flags: superreview?(alecf) → superreview+
(Assignee)

Updated

15 years ago
Attachment #123466 - Flags: approval1.4?

Comment 4

15 years ago
Comment on attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console

moving approval request forward.
Attachment #123466 - Flags: approval1.4? → approval1.4.x?

Comment 5

15 years ago
Comment on attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console

If someone can land this on the 1.4 branch quickly it can make the 1.4.1
release.

a=asa (on behalf of drivers) for checkin to the 1.4 branch.
Attachment #123466 - Flags: approval1.4.x? → approval1.4.x+
(Assignee)

Updated

15 years ago
Attachment #123466 - Flags: approval1.5b?

Comment 6

15 years ago
Comment on attachment 123466 [details] [diff] [review]
patch to restore green arrows in javascript console

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.
Attachment #123466 - Flags: approval1.5b? → approval1.5b+

Comment 7

15 years ago
checked in
Assignee: hewitt → abecevello
(Assignee)

Comment 8

15 years ago
marking FIXED
patch has been checked into both the trunk and 1.4 branch
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Blocks: 224532
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.