Address failures to commit/purge various SharedPreferences used by Sync

NEW
Unassigned

Status

()

Firefox for Android
Android Sync
P3
normal
11 months ago
2 months ago

People

(Reporter: Grisha, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 months ago
It's possible that our attempts to reset collections' last-synced timestamps and stage-specific persisted repository state (introduced in Bug 1291821) will fail. We're persisting via SharedPreferences.Editor's commit call, which might fail due to various I/O issues. This is supposed to be rare, very rare, but most of our code using `commit` never checks for failures.

In case of un-purged timestamps and/or repository state, unwanted side-effects largely include incorrect are missing records on consequent syncs

One way to address this in a context of sync is to further prefix PrefsBranch with syncID and probably current clientID, which should help limit negative impact of any state that might linger past its lifetime.
Priority: -- → P2
(Reporter)

Updated

6 months ago
Priority: P2 → P3

Updated

2 months ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.