1332434 - Add support for enabling Baidu geolocation via a preference

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Mike Kaply [:mkaply]]

The MozillaOnline version of Firefox currently has code changes to enable Baidu geolocation:

https://github.com/MozillaOnline/gecko-dev/commit/924b209f06992083a91b6f6e14af6d91c281d192

We should provide this in the core Fennec and allow it to be turned on via a preference for the Chinese distribution.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

> BaiduLBS_Android.jar

I wonder if the source code of this lib is available.

Comment 2

[Mike Kaply [:mkaply]]

It does not appear to be. The jar is obtained from here:

http://lbsyun.baidu.com/index.php?title=android-locsdk

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1332434 - Add Baidu location support code (no libraries).

Review commit: https://reviewboard.mozilla.org/r/148634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148634/

Comment 4

[Mike Kaply [:mkaply]]

So while we are waiting on legal reviews, I thought it would be worthwhile to at least get some code together.

This code is based on the MozillaOnline patch:

https://github.com/MozillaOnline/gecko-dev/commit/e88d7578327aa9005e375c27bfdef107eff94c71

but I've worked to completely separate the Baidu code out so that it can be turned on/off with a build switch.

All Mozilla China has to do is drop in the jar and so and things will build.

I'm not sure if the locations of these files are correct; it's based on the work they did.

Comment 5

[Mike Kaply [:mkaply]]

Note that for this to pass tests, we'll need a way to turn off Gradle linting for the BaiduLocation.java file since none of the references in the file are valid without the .jar.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8877306 [details]
Bug 1332434 - Add Baidu location support code (no libraries).

https://reviewboard.mozilla.org/r/148634/#review154052

Comment 7

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 8

[Mike Kaply [:mkaply]]

No more fennec.