Closed
Bug 1332448
Opened 7 years ago
Closed 7 years ago
SETA: Remove taskrequest feaure from treeherder seta
Categories
(Tree Management Graveyard :: Treeherder: SETA, defect)
Tree Management Graveyard
Treeherder: SETA
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
Once the gecko decision task is making the decision when to call SETA (Bug 1329783), there will be no need to use the TaskRequest counter in TH, so it can be removed: https://github.com/mozilla/treeherder/blob/master/treeherder/seta/job_priorities.py#L93-L112 https://github.com/mozilla/treeherder/blob/master/treeherder/seta/models.py#L9-L31
|
Assignee | |
Comment 1•7 years ago
|
||
This patch will include removing the counter and timeout code - we've decided to have the gecko decision task decide when to call SETA and when to run all of the jobs; instead of handling that inside the SETA API itself.
|
||
Comment 2•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8830053 -
Flags: review?(jmaher)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8830053 [details] [review] [treeherder] rwood-moz:bug1332448 > mozilla:master feedback left in the PR, one issue I had.
Attachment #8830053 -
Flags: review?(jmaher) → review-
|
|
Assignee | |
Comment 4•7 years ago
|
||
Comment on attachment 8830053 [details] [review] [treeherder] rwood-moz:bug1332448 > mozilla:master Thanks guys, PR updated
Attachment #8830053 -
Flags: review- → review?(jmaher)
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8830053 [details] [review] [treeherder] rwood-moz:bug1332448 > mozilla:master looks great
Attachment #8830053 -
Flags: review?(jmaher) → review+
|
||
Comment 6•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/6d6f904317c86c776ff3fdfa4c2d085c003f38c9 Bug 1332448 - Remove taskrequest counter and timeout from seta (#2103)
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Treeherder → Treeherder: SETA
|
||
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•