133246 - basebrowser-win doens't full work with gnumake

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: APIs, defect)

Description

[TVL]

[ there doesn't seem to be a component for embedding:windows, which is where is 
really belongs? ]

there's an entry trying to use a wildcard ('*'), that doesn't seem to pick 
things up correctly, when you do a make in embedding/config you get this error 
line:

Warning: ../../dist/binresdtd* is not a file or directory (./basebrowser-win, 
Embed, 131).  Skipped...

either the makefiles need to sort out how to support the wildcard or things 
probably need to be listed instead.

(there are also a lot of other possible errors on that make, it's not clear how 
many are because of my MOZCONFIG vs. stale entries in basebrowser-win)

Comment 1

[Adam Lock]

GNU make is choking on the backslashes in basebrowser-win. Changing these to
foward slashes fixes the make errors but reveals some files are missing from the
Mozilla build and can't be copied.

I'm fetching a new build to catch up with the Friday changes to see if these
issues were fixed. If not I'll attach a log file.

Comment 2

[hacker formerly known as [e-mail]]

This works fine in my tree and the embed-win32.zip from latest-WIN_GMAKE (dated
yesterday) has a working mfcembed dist.  The error looks like pkgcp.pl was
called with --os unix set instead of --os dos.  That problem was fixed on the
trunk early Friday morning.

Comment 3

[Adam Lock]

Verifying it works and marking INVALID.

Comment 4

[TVL]

the pull i have from friday has the right OS flag in it, so i'm not sure why
it's failing for me but not off the latest nightly snapshot.  i'm updating my
build to try again.  where can i pickup a nightly with gnumake and i'll see what
it does on my system (incase it's the environment effecting things in some way)?
 the nightly on ftp.mozilla.org doesn't seem to be gnumake based for windows.

Comment 5

[Adam Lock]

I had to run "sh configure" to get the Makefile to match the Makefile.in. I
would try that first to see if that's the issue.

The Makefile.in should have a line that sets _PLATFORM to dos at the top.

Comment 6

[TVL]

i'm still getting the failure.

in one of your trees going into embedding/config and do a

  'make WINAPP=NOTHING > foo.txt'

i'm still showing that the wildcard isn't being handled.

[i'll attach the errors i see in just a second]

Comment 7

[TVL]

here are the errors i still get (tip pulled yesturday).  the 15th is the 
wildcard appearing to fail.

Warning: File or 
directory "../../dist/Embed/tmpchrome/classic/skin/classic/communicator/dialogOv
erlay.css" does not exist.
Warning: File or 
directory "../../dist/Embed/tmpchrome/classic/skin/classic/communicator/smallhea
der-bg.gif" does not exist.
Warning: File or directory "../../dist/Embed/tmpchrome/help/content/help" does 
not exist.
Warning: File or 
directory "../../dist/Embed/tmpchrome/classic/skin/classic/communicator/help.css
" does not exist.
Warning: File or 
directory "../../dist/Embed/tmpchrome/classic/skin/classic/forms" does not 
exist.
Name "main::lineno" used only once: possible typo 
at ../../xpinstall/packager/pkgcp.pl line 48.
Name "main::line" used only once: possible typo 
at ../../xpinstall/packager/pkgcp.pl line 42.
Warning: component directory "Embed" already exists in "../../dist".
Warning: package error or possible missing or unnecessary file: mozreg.dll 
(./basebrowser-win, 55).
Warning: package error or possible missing or unnecessary file: img3250.dll 
(./basebrowser-win, 59).
Warning: package error or possible missing or unnecessary file: jpeg3250.dll 
(./basebrowser-win, 60).
Warning: package error or possible missing or unnecessary file: 
components\nspng.dll (./basebrowser-win, 62).
Warning: package error or possible missing or unnecessary file: 
components\cookie.dll (./basebrowser-win, 86).
Warning: package error or possible missing or unnecessary file: 
moz_art_lgpl.dll (./basebrowser-win, 129).
Warning: ../../dist/binresdtd* is not a file or directory (./basebrowser-win, 
Embed, 131).  Skipped...
Warning: package error or possible missing or unnecessary file: 
components\nsgif.dll (./basebrowser-win, 156).
Warning: package error or possible missing or unnecessary file: 
components\nsjpg.dll (./basebrowser-win, 157).
Warning: package error or possible missing or unnecessary file: 
components\wallet.dll (./basebrowser-win, 186).
Warning: package error or possible missing or unnecessary file: 
components\wallet.xpt (./basebrowser-win, 187).
Warning: package error or possible missing or unnecessary file: 
components\xpcom_eventloop_windows.xpt (./basebrowser-win, 264).
Warning: package error or possible missing or unnecessary file: 
components\xpcom_eventloop_xp.xpt (./basebrowser-win, 265).
Warning: package error or possible missing or unnecessary file: 
components\xpcom_nativeapp.xpt (./basebrowser-win, 267).

Comment 8

[hacker formerly known as [e-mail]]

I'm not worried about those warnings.  Some of those are files that aren't built
dynamically in the gmake build (jpeg, zlib & mozreg).   Others are obsolete from
both builds afaik (xpcom_eventloop_xp.xpt,xpcom_nativeapp.xpt,nsjpg.dll,nspng.dll).
The real question is: does the embedding app work when you build?

Comment 9

[TVL]

mfcembed seems to work.  so i guess the wildcard entry is stale/not really needed?