1332463 - Separate progress-related functionality out of ContentDelegate into ProgressDelegate

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Dylan Roeh (:droeh) (he/him)]

onPageStart, onPageProgress, onPageStop, and possibly onSecurityChanged should be moved out of ContentDelegate and into ProgressDelegate.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: GeckoView ProgressListener

This implements ProgressListener (with onPageStart, onPageStop, and onSecurityChanged) and updates the example app to log those events.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8834572 [details] [diff] [review]
GeckoView ProgressListener

Review of attachment 8834572 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/geckoview.js
@@ +33,5 @@
>  function startup() {
>    dump("zerdatime " + Date.now() + " - geckoview chrome startup finished.");
>  
>    content = new GeckoViewContent(window, document.getElementById("content"), WindowEventDispatcher);
> +  progress = new GeckoViewProgress(window, document.getElementById("content"), WindowEventDispatcher);

Put `document.getElementById("content")` in a variable so you can reuse it

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java
@@ +529,5 @@
> +        * The security status has been updated.
> +        * @param view The GeckoView that initiated the callback.
> +        * @param status The new security status.
> +        */
> +        public void onSecurityChanged(GeckoView view, int status);

Please define constants for `status`

::: mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/GeckoViewActivity.java
@@ +110,5 @@
> +
> +        @Override
> +        public void onSecurityChanged(GeckoView view, int status) {
> +            String statusString;
> +            if ((status & 1) > 0) {

Use constants

@@ +117,5 @@
> +                statusString = "secure";
> +            } else if ((status & 4) > 0) {
> +                statusString = "insecure";
> +            } else {
> +                statusString = "what?";

"unknown"

::: mobile/android/modules/moz.build
@@ +33,5 @@
>  
>  # GeckoView-sepcific modules added separately.
>  EXTRA_JS_MODULES += [
> +    'GeckoViewContent.jsm',
> +    'GeckoViewProgress.jsm'

Your patch doesn't include GeckoViewProgress.jsm

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: GeckoView ProgressListener v1.1

Updated with Jim's suggested changes and rebased around Eugen's patch for bug 1322592; carrying over Jim's r+.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f88c8fc68103
Implement ProgressListener. r=jchen

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f88c8fc68103