1332573 - Can't run mochitest with "--tag"

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Alastor Wu [:alwu]]

I've tried different kinds of tag names, and all of them can't be executed successfully.

Can be reproduced on Nightly, and both on OSX and Linux.

---

Error running mach:

    ['mochitest', '--tag', 'audiochannel']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

UnboundLocalError: local variable 'status' referenced before assignment

  File "/Users/Alastor/mozilla-central/testing/mochitest/mach_commands.py", line 408, in run_mochitest_general
    **harness_args)
  File "/Users/Alastor/mozilla-central/testing/mochitest/mach_commands.py", line 158, in run_desktop_test
    result = mochitest.run_test_harness(parser, options)
  File "/Users/Alastor/build_mc_obj/_tests/testing/mochitest/runtests.py", line 2711, in run_test_harness
    result = runner.runTests(options)
  File "/Users/Alastor/build_mc_obj/_tests/testing/mochitest/runtests.py", line 2228, in runTests
    return self.runMochitests(options, testsToRun)
  File "/Users/Alastor/build_mc_obj/_tests/testing/mochitest/runtests.py", line 2167, in runMochitests
    result = self.doTests(options, testsToRun)
  File "/Users/Alastor/build_mc_obj/_tests/testing/mochitest/runtests.py", line 2478, in doTests

Comment 1

[Andrew Halberstadt [:ahal]]

I think this was regressed by bug 1286312. Once I get mochitest selftests running, I'll make sure a test is added for --tag.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1332573 - Always set status in mochitest even if no tests were found,

This fixes a regression in bug 1332573 where if no tests are found by the getActiveTests
function, the status variable never gets set. This ensures that we always set status, and
that it will be set to a non-zero return code if any of the calls to runApp fail.

Review commit: https://reviewboard.mozilla.org/r/106104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106104/

Comment 3

[Paul Yang [:pyang] (away)]

Comment on attachment 8828811 [details]
Bug 1332573 - Always set status in mochitest even if no tests were found,

https://reviewboard.mozilla.org/r/106104/#review107376

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c61b0e70d0cf
Always set status in mochitest even if no tests were found, r=pyang

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c61b0e70d0cf