Closed Bug 1332576 Opened 3 years ago Closed 3 years ago

Perma failure in js1_8_5/extensions/sharedtypedarray.js | (args: "") when trunk moves to aurora

Categories

(Core :: JavaScript Engine, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 + fixed

People

(Reporter: cbook, Assigned: lth)

References

()

Details

Attachments

(1 file)

found during uplift simulations


TEST-UNEXPECTED-FAIL | js1_8_5/extensions/sharedtypedarray.js | (args: "")
https://treeherder.mozilla.org/logviewer.html#?job_id=70591055&repo=try

## js1_8_5/extensions/sharedtypedarray.js: rc = 3, run time = 0.242187

[task 2017-01-20T08:35:12.526543Z] js1_8_5/extensions/sharedtypedarray.js:179:5 ReferenceError: sharedAddress is not defined

[task 2017-01-20T08:35:12.526573Z] Stack:

[task 2017-01-20T08:35:12.526609Z]   testClone1@js1_8_5/extensions/sharedtypedarray.js:179:5

[task 2017-01-20T08:35:12.526642Z]   @js1_8_5/extensions/sharedtypedarray.js:254:1

[task 2017-01-20T08:35:12.526687Z] TEST-UNEXPECTED-FAIL | js1_8_5/extensions/sharedtypedarray.js | (args: "")
[Tracking Requested - why for this release]:
perma failure / tree closing reason when trunk moves to aurora
The problem here is that 'sharedAddress', which is a shell built-in for getting the actual address of a SharedArrayBuffer's shared memory block which we use to test structured cloning, is nightly-only.  There are therefore some test cases that should only run on Nightly or should guard on the presence of this primitive.
Guard calls to sharedAddress with a test of its existence.

I could have widened the guard but it seems to me that it's useful to keep it narrow so that we test serialize/deserialize as much as we can, even if we can't test the buffer address.
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Attachment #8828753 - Flags: review?(bbouvier)
Attachment #8828753 - Flags: review?(bbouvier) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b510027eae07a61a61e80177bc327653cfe6b0b
Bug 1332576 - Guard a test primitive that may not be in all shells. r=bbouvier
Tracking 53+ for this perma failure.
https://hg.mozilla.org/mozilla-central/rev/8b510027eae0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.