1332588 - ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file RestyleManagerBase.cpp, line 915

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: transform-assertion.html

Attachment file spews below assertion:

ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file /home/ikezoe/central/layout/base/RestyleManagerBase.cpp

Comment 1

[Chris Peterson [:cpeterson]]

I hit this assertion repeatedly when loading mozilla.slack.com:

[Child 57020, Main Thread] ###!!! ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file layout/base/RestyleManager.cpp, line 1138
[Child 57020, Main Thread] ###!!! ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file layout/base/RestyleManager.cpp, line 1138
[Child 57020, Main Thread] ###!!! ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file layout/base/RestyleManager.cpp, line 1138
[Child 57020, Main Thread] ###!!! ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file layout/base/RestyleManager.cpp, line 1138

Comment 2

[alexander :surkov (:asurkov)]

I hit this assertion when repeating steps from bug 1268901

Comment 3

[Chris Peterson [:cpeterson]]

I hit this assertion failure when trying to open an email in Gmail.

Comment 4

[Chris Peterson [:cpeterson]]

This assertion was added in bug 1290335:

https://searchfox.org/mozilla-central/rev/62ce7b988d85e160ab96624001f0d1c33b0089ee/layout/base/RestyleManager.cpp#1175-1181

Comment 5

[Emilio Cobos Álvarez (:emilio)]

It was not. It was only moving code around, see https://hg.mozilla.org/mozilla-central/rev/a8d9d9b868d60a58860db5c6b429fdb0bda1d148.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Presumably we should also drop nsChangeHint_UpdateTransformLayer here along with nsChangeHint_UpdatePostTransformOverflow.

Let's see if what happens on try;
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b33125977930765b6bdb71e0b1f1c3543aa1b07

Comment 7

[Hiroyuki Ikezoe (:hiro)]

The try run told us that there is a pre-exising issue that we don't set NS_FRAME_MAY_BE_TRANSFORMED property here in KeyframeEffect::UpdateEffectSet.

Pushed another try;
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbfd4723e84c1be75439d32e0a837fa505273fef

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1332588 - Set NS_FRAME_MAY_BE_TRANSFORMED bit in nsIFrame::SetMayHaveTransformAnimation. r?boris

Without this change stacking-context-transform-changing-keyframe.html will fail
with the next change, since we will incorrectly remove
nsChangeHint_UpdateTransformLayer from the target nsIFrame if the frame doesn't
have NS_FRAME_MAY_BE_TRANSFORMED bit.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1332588 - Drop nsChangeHint_UpdateTransformLayer on the frame that we don't support transform. r?boris

Depends on D75049

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1332588 - Drop the code to set NS_FRAME_MAY_BE_TRANSFORMED introduced in bug 1524480. r?boris

The right place to set the bit was in
nsIFrame::SetMayHaveTransformAnimations() (i.e. when we call
KeyframeEffect::UpdateEffectSet) for cases where we add transform animations.
on an nsIFrame which has been already initialized.

Depends on D75050

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1332588 - Drop explicit setting of dom.animations.mainthread-synchronization-with-geometric-animations. r?boris

Since we no longer see the "Unexpected UpdateTransformLayer hint" assertion
on those tests.

Depends on D75051

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/641d8019eb5e
Set NS_FRAME_MAY_BE_TRANSFORMED bit in nsIFrame::SetMayHaveTransformAnimation. r=boris
https://hg.mozilla.org/integration/autoland/rev/194aab18de04
Drop nsChangeHint_UpdateTransformLayer on the frame that we don't support transform. r=boris
https://hg.mozilla.org/integration/autoland/rev/2eb1dfb0ba11
Drop the code to set NS_FRAME_MAY_BE_TRANSFORMED introduced in bug 1524480. r=boris
https://hg.mozilla.org/integration/autoland/rev/a14a719778ae
Drop explicit setting of dom.animations.mainthread-synchronization-with-geometric-animations. r=boris

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/641d8019eb5e
https://hg.mozilla.org/mozilla-central/rev/194aab18de04
https://hg.mozilla.org/mozilla-central/rev/2eb1dfb0ba11
https://hg.mozilla.org/mozilla-central/rev/a14a719778ae