Update browsingData to use removeAllLogins when that method supports a since date

NEW
Assigned to

Status

()

Toolkit
WebExtensions: Compatibility
P3
normal
3 months ago
13 days ago

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [browsingData]triaged)

Attachments

(4 obsolete attachments)

(Assignee)

Description

3 months ago
As discussed at https://bugzilla.mozilla.org/show_bug.cgi?id=1321303#c130, there's an issue with the current implementation of password removal if a user has a Master Password set and chooses not to enter it when this API attempts to clear passwords. Removing the call to getAllLogins from ext-browsingData.js and replacing it with a call to removeAllLogins will fix this, but in order to do that we'll need removeAllLogins to support passing in a "since" date.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

16 days ago
Attachment #8856191 - Attachment is obsolete: true
Attachment #8856191 - Flags: review?(bob.silverberg)

Updated

16 days ago
Attachment #8856192 - Attachment is obsolete: true
Attachment #8856192 - Flags: review?(bob.silverberg)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

13 days ago
mozreview-review
Comment on attachment 8856193 [details]
Bug 1332613 - Add support for removeAllLogins to take an optional parameter 'since';

https://reviewboard.mozilla.org/r/128132/#review131390

Thomas, thanks for doing this, but this patch should be attached to bug 1332611, which was opened for that purpose, and I wouldn't be the one to review the changes, it would be someone responsible for the nsILoginManager code.
Attachment #8856193 - Flags: review?(bob.silverberg)
(Assignee)

Comment 6

13 days ago
mozreview-review
Comment on attachment 8856194 [details]
Bug 1332613 - Remove the call to getAllLogins from browsingData.remove(passwords) in favor of calling removeAllLogins(since);

https://reviewboard.mozilla.org/r/128134/#review131392

This looks good, Thomas, but its review will have to wait for bug 1332611 to land, so I'm removing my review flag for now. Please re-flag me for review once the changes for bug 1332611 land, changing the behaviour of removeAllLogins.
Attachment #8856194 - Flags: review?(bob.silverberg)

Updated

13 days ago
Attachment #8856193 - Attachment is obsolete: true

Updated

13 days ago
Attachment #8856194 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.