1332613 - Update browsingData to use removeAllLogins when that method supports a since date

Status: REOPENED

(WebExtensions :: Compatibility, defect, P3)

Description

[Bob Silverberg [:bsilverberg]]

As discussed at https://bugzilla.mozilla.org/show_bug.cgi?id=1321303#c130, there's an issue with the current implementation of password removal if a user has a Master Password set and chooses not to enter it when this API attempts to clear passwords. Removing the call to getAllLogins from ext-browsingData.js and replacing it with a call to removeAllLogins will fix this, but in order to do that we'll need removeAllLogins to support passing in a "since" date.

Comment 1

[Thomas Wisniewski]

Attachment: Bug 1332613 - Add support for removeAllLogins to take an optional parameter 'since';

Review commit: https://reviewboard.mozilla.org/r/128126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128126/

Comment 2

[Thomas Wisniewski]

Attachment: Bug 1332613 - Remove the call to getAllLogins from browsingData.remove(passwords) in favor of calling removeAllLogins(since);

Review commit: https://reviewboard.mozilla.org/r/128128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128128/

Comment 3

[Thomas Wisniewski]

Attachment: Bug 1332613 - Add support for removeAllLogins to take an optional parameter 'since';

Review commit: https://reviewboard.mozilla.org/r/128132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128132/

Comment 4

[Thomas Wisniewski]

Attachment: Bug 1332613 - Remove the call to getAllLogins from browsingData.remove(passwords) in favor of calling removeAllLogins(since);

Review commit: https://reviewboard.mozilla.org/r/128134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128134/

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8856193 [details]
Bug 1332613 - Add support for removeAllLogins to take an optional parameter 'since';

https://reviewboard.mozilla.org/r/128132/#review131390

Thomas, thanks for doing this, but this patch should be attached to bug 1332611, which was opened for that purpose, and I wouldn't be the one to review the changes, it would be someone responsible for the nsILoginManager code.

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8856194 [details]
Bug 1332613 - Remove the call to getAllLogins from browsingData.remove(passwords) in favor of calling removeAllLogins(since);

https://reviewboard.mozilla.org/r/128134/#review131392

This looks good, Thomas, but its review will have to wait for bug 1332611 to land, so I'm removing my review flag for now. Please re-flag me for review once the changes for bug 1332611 land, changing the behaviour of removeAllLogins.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.