[tracking] CSS linting errors

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: agibson, Unassigned)

Tracking

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
We recently added Stylelint [1] to our CI on bedrock [2] to help us automatically pick out CSS errors and styling preferences in pull requests.

[1] http://stylelint.io/
[2] https://github.com/mozilla/bedrock/pull/4567

There are currently a lot of 'warning' class linting errors in the existing Less and Sass files that make up the pages on mozorg.

This is a tracking bug for fixing those linting errors. These dependent bugs will be classed as "good first bugs" for contributors to take on.
(Reporter)

Updated

a year ago
Depends on: 1332647
(Reporter)

Updated

a year ago
Depends on: 1332650
(Reporter)

Updated

a year ago
Depends on: 1332654
(Reporter)

Updated

a year ago
Depends on: 1332663
(Reporter)

Updated

a year ago
Depends on: 1332665
(Reporter)

Updated

a year ago
Depends on: 1332667
(Reporter)

Updated

a year ago
Depends on: 1332672
(Reporter)

Updated

a year ago
Depends on: 1332674
(Reporter)

Updated

a year ago
Depends on: 1332675
(Reporter)

Updated

a year ago
Depends on: 1332677
(Reporter)

Updated

a year ago
Depends on: 1332678
(Reporter)

Updated

a year ago
Depends on: 1336385

Comment 1

a year ago
looking at the current css (as well as fixes to the linting errors), i've noticed that there's no standardisation of whether single or double quotes should be used. 

Should this be added to the stylelint? if yes,what would be the preference? single or double?
Flags: needinfo?(agibson)
(Reporter)

Comment 2

11 months ago
(In reply to Rachel from comment #1)
> looking at the current css (as well as fixes to the linting errors), i've
> noticed that there's no standardisation of whether single or double quotes
> should be used. 
> 
> Should this be added to the stylelint? if yes,what would be the preference?
> single or double?

Good suggestion - feel free to open a pull request to add the rule! (you can also file a bug for it if you wish, blocking this tracking bug)
Flags: needinfo?(agibson)
(Reporter)

Comment 3

11 months ago
Preference would be single quotes looking at what we use most often.
(Reporter)

Comment 4

11 months ago
All dependent bugs have been resolved, thanks to everyone who contributed :)

We removed all warning-level Stylelint settings in https://github.com/mozilla/bedrock/pull/4669, so going forward builds will error if any rules are broken. We're going to see how much noise this creates, and can always re-evaluate if it becomes too troublesome .
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.