Closed Bug 1332648 Opened 7 years ago Closed 7 years ago

remove bogus string radix/case #defines

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

remove bogus string radix/case #defines
1.01 KB, patch
erahm
: review+
Details | Diff | Splinter Review 
Nothing uses these defines, so we should remove them lest anybody get
confused.  I would have also removed kAutoDetect (who would want to do
this?!), but kAutoDetect is used in one place in the tree, and I didn't
want to hold up the deletion of these two items with trying to fix that
one place.

        Attachment #8828848 -
        Flags: review?(erahm)

    
    

    
  
Comment on attachment 8828848 [details] [diff] [review]
remove bogus string radix/case #defines

Review of attachment 8828848 [details] [diff] [review]:
-----------------------------------------------------------------

The kAutoDetect case should be easy enough to replace, just try w/ 10, then 16. We could then make |nsTString_CharT::ToInteger| slightly less awful. I guess that's better for a follow-up though.

        Attachment #8828848 -
        Flags: review?(erahm) → review+

    
    

    
  
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c20b49c1ff85
remove bogus string radix/case #defines; r=erahm

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c20b49c1ff85
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox53:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

          You need to log in
          before you can comment on or make changes to this bug.