Closed Bug 1332671 Opened 7 years ago Closed 7 years ago

Changing the search engines list doesn't enable the "Restore defaults" button

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1327953
Tracking Status
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: pauly, Unassigned)

References

Details

(Keywords: regression)

[Affected versions]:
- 50-53

[Affected platforms]:
- all

[Steps to reproduce]:
1. Open about:preferences#search
2. Remove a few search engines from the list starting from bottom to top

[Expected result]:
- "Restore defaults" button is available

[Actual result]:
- "Restore defaults" button grayed out

[Regression range]:
- starting with FX 46 release

[Additional notes]:
- "Restore defaults" button becomes available after a browser restart
Moreover, adding a new search engine (eg. "youtube") also doesn't enable the "Restore defaults" button
Summary: Changing the search engine settings doesn't enable the "Restore defaults" button → Changing the search engines list doesn't enable the "Restore defaults" button
Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=861971c670e1fe27c8bf43833831d7ce17b46f00&tochange=503ebfe13cd2f079829f4a4c8b7e860b4989403f

Regressed by: 503ebfe13cd2	Jeremy Francispillai — Bug 1122618 - Added change to rebuild the defaultEngineDropDown whenever the default engine is changed. Separated the code performing the changes and displaying the changes when removing/adding engines. r=florian.
Blocks: 1122618
Flags: needinfo?(jeremyjpf)
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jeremyjpf)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.