1332697 - Pulse publishing timeout

Status: RESOLVED FIXED

(MozReview Graveyard :: Infrastructure, defect)

Description

[Steven MacLeod [:smacleod]]

The MozReview extension is always timing out when trying to publish to pulse. It appears the firewall is blocking access.

Comment 1

[Steven MacLeod [:smacleod]]

Since this has been happening for a while and no one has complained about the pulse messages being gone, I've disabled the publishing (by editing "/mozreview-settings.json" on the webheads).

Comment 2

[Amy Rich [:arr] [:arich]]

Probably the same issue with the IP changing, ccing mcote.

Comment 3

[Mark Côté [:mcote]]

It is; smacleod & I were talking about it.  It's not critical, so as smacleod says we've shut it down until the IP situation is resolved.

Comment 4

[Jan Keromnes [:janx]]

Release Management is developing a static-analysis-review-bot [0], and we would like to use the Pulse message "mozreview.commits.published" [1] to detect new changesets to be reviewed, in order to run quick static analysis checks (using clang-tidy on taskcluster) and publish quick critical feedback on the review.

I would like to understand what needs to be done to fix MozReview's Pulse publishing (i.e. this bug).

Amy, could you please elaborate on the IP change issue you mentioned in comment 2, and how it can be addressed?

[0] https://github.com/mozilla-releng/services/issues/240
[1] https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/notifications.html#mozreview-commits-published

Comment 5

[Amy Rich [:arr] [:arich]]

I believe that got solved when mcote got a static IP.

Comment 6

[Mark Côté [:mcote]]

Right.  Pulse's addresses should stay as 52.52.230.243, 52.52.230.113, and 52.8.30.112.  Guess we need some firewall updates.  Fubar, I think that'd be in your court?

Comment 7

[Kendall Libby [:fubar] (he/him)]

Which nodes need to communicate with pulse? The web nodes and/or the hg node?

Comment 8

[Kendall Libby [:fubar] (he/him)]

Hah, it's in #c1, nvm. Will file bug with netops.

Comment 9

[Kendall Libby [:fubar] (he/him)]

This should be good to re-enable, but I'll let someone on the mozreview team handle that and test.

Comment 10

[Jan Keromnes [:janx]]

Thanks mcote and fubar!

Smacleod, could you please try re-enabling MozReview's publishing to Pulse?

Comment 11

[Steven MacLeod [:smacleod]]

(In reply to Jan Keromnes [:janx] from comment #10)
> Thanks mcote and fubar!
> 
> Smacleod, could you please try re-enabling MozReview's publishing to Pulse?

The configuration on each webhead has been updated to re-enable pulse publishing. Messages should start showing up after the next deploy (RB must be restarted).

Comment 12

[Jan Keromnes [:janx]]

We are receiving "mozreview.commits.published" and "mozreview.review.published" Pulse messages again on [0], so I believe that this bug can be resolved as fixed. Many thanks!

[0] https://tools.taskcluster.net/pulse-inspector/#!((exchange:exchange/mozreview/,routingKeyPattern:%23))