133273 - URL field not linked after show_bug.cgi templatization

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[David D. Kilzer (ddk)]

The template uses bug.url but the URL is actually stored in
bug.bug_file_loc.  Template also includes use of arcane
'FILTER url'.  Patch coming shortly.

Comment 1

[David D. Kilzer (ddk)]

Target -> 2.16.  Keywords: patch, review, regression.

Comment 2

[David D. Kilzer (ddk)]

Attachment: Patch v.1

Change bug.url -> bug.bug_file_loc in template.

Comment 3

[David D. Kilzer (ddk)]

Bug 110012 is the original show_bug.cgi templatization patch.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 75970 [details] [diff] [review]
Patch v.1

You'll need to put the "FILTER url" back :-)

Gerv

Comment 5

[David D. Kilzer (ddk)]

I believe 'FILTER url' was deprecated in favor of 'FILTER uri'.
I will upload another patch.

BTW, if bug.bug_file_loc has a 'FILTER uri', then shouldn't
bug.milestoneurl use one, too (like 173)?

            <a href="[% bug.milestoneurl %]">Target Milestone</a>:

Comment 6

[David D. Kilzer (ddk)]

Attachment: Patch v.2

Now with 'FILTER uri' added.

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 75996 [details] [diff] [review]
Patch v.2

2xr=gerv. The answer to your question is "yes, probably :-)". 

File another bug? <ducks>

Gerv

Comment 8

[David D. Kilzer (ddk)]

Filed Bug 133372 regarding use of 'FILTER uri' on bug.milestoneurl.

Comment 9

[Andreas Franke (gone)]

Gerv, looks like you replaced the second occurrence of bug.url, but not the one
at the IF:

<         [% IF bug.url %]
---
>         [% IF bug.bug_file_loc %]

Is there a bug somewhere about renaming the bug_file_loc to something
reasonable?

Comment 10

[David D. Kilzer (ddk)]

Should this bug be marked RESOLVED DUPLICATE of Bug 133425?

Comment 11

[David D. Kilzer (ddk)]

The fixes in this bug were checked into CVS in two parts of
the template/default/show/show_bug.html.tmpl file:

- v1.3 fixed the [% bug.url FILTER url %] line

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/webtools/bugzilla/template/default/show&command=DIFF_FRAMESET&file=show_bug.html.tmpl&rev1=1.2&rev2=1.3&root=/cvsroot

- v1.6 fixed the [% IF bug.url %] line

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/webtools/bugzilla/template/default/show&command=DIFF_FRAMESET&file=show_bug.html.tmpl&rev1=1.5&rev2=1.6&root=/cvsroot