Closed Bug 1332752 Opened 5 years ago Closed 5 years ago

Add some logging to TimeoutManager

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Add some logging to TimeoutManager
13.74 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
I'm going to add some logging which can be helpful with the upcoming manual tests on TimeoutManager.
Attachment #8829021 - Flags: review?(bkelly)
Comment on attachment 8829021 [details] [diff] [review]
Add some logging to TimeoutManager

Review of attachment 8829021 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a huge fan of permanent log statements like this, but ok.
Attachment #8829021 - Flags: review?(bkelly) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d245077d0c9b
Add some logging to TimeoutManager; r=bkelly
(In reply to Ben Kelly [:bkelly] from comment #2)
> I'm not a huge fan of permanent log statements like this, but ok.

May I ask why out of curiosity?
(In reply to :Ehsan Akhgari from comment #4)
> May I ask why out of curiosity?

Having spent a lot of time on these in the past I found that:

1) Each person tends to want different messages
2) Putting them all in makes things spammy
3) Consequently they are a net negative compared to people just writing a printf when they need it

But like I said, its just a preference and I'm not blocking you.
https://hg.mozilla.org/mozilla-central/rev/d245077d0c9b
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.