1332752 - Add some logging to TimeoutManager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

I'm going to add some logging which can be helpful with the upcoming manual tests on TimeoutManager.

Comment 1

[(no longer active)]

Attachment: Add some logging to TimeoutManager

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8829021 [details] [diff] [review]
Add some logging to TimeoutManager

Review of attachment 8829021 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a huge fan of permanent log statements like this, but ok.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d245077d0c9b
Add some logging to TimeoutManager; r=bkelly

Comment 4

[(no longer active)]

(In reply to Ben Kelly [:bkelly] from comment #2)
> I'm not a huge fan of permanent log statements like this, but ok.

May I ask why out of curiosity?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

(In reply to :Ehsan Akhgari from comment #4)
> May I ask why out of curiosity?

Having spent a lot of time on these in the past I found that:

1) Each person tends to want different messages
2) Putting them all in makes things spammy
3) Consequently they are a net negative compared to people just writing a printf when they need it

But like I said, its just a preference and I'm not blocking you.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d245077d0c9b