1332766 - Prevent blocklist-clients from swallowing signature verification errors

Status: RESOLVED INVALID

(Firefox :: Remote Settings Client, defect)

Description

[Mark Goodwin [:mgoodwin]]

When a collection signature on a partial update does not verify, the blocklist client will attempt to rectify the situation by requesting the whole collection and attempting to verify the signature again. I this retry mechanism also fails, while the signature verifier throws, the error is swallowed.

The effect of this is that, despite the fact that collection sync failed, the blocklist-updater records state to the effect that sync succeeded (and, thus, the client won't sync again until some other change happens).

Comment 1

[Mathieu Leplatre [:leplatrem]]

According to this code:
https://searchfox.org/mozilla-central/rev/8f89901f2d69d9783f946a7458a6d7ee70635a94/services/settings/remote-settings.js#399-416

It's not the case anymore. Closing.