Baldr: tweak memory/table limits

RESOLVED FIXED in Firefox 54

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8828997 [details] [diff] [review]
tweak-limits

This patch reflects updated thinking on limits (soon to be in v8) that only the *initial* memory/table lengths should be clamped.  The maximums can be anything since these are just best-effort reservations that don't trigger failure.
Attachment #8828997 - Flags: review?(bbouvier)
Comment on attachment 8828997 [details] [diff] [review]
tweak-limits

Review of attachment 8828997 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thanks.

::: js/src/wasm/WasmValidate.cpp
@@ -932,5 @@
>          return false;
>  
>      CheckedInt<uint32_t> initialBytes = memory.initial;
>      initialBytes *= PageSize;
> -    if (!initialBytes.isValid() || initialBytes.value() > uint32_t(INT32_MAX))

(yay, one fewer raw magical constant!)
Attachment #8828997 - Flags: review?(bbouvier) → review+

Comment 2

a year ago
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e24ae48855ba
Baldr: tweak memory/table limits (r=bbouvier)

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e24ae48855ba
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.