1332776 - Ensure that the dom.min_tracking_timeout_value pref takes effect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Without this, we would only try to clamp the timeout for background
windows and nested timeouts.  We should also do this for all timeouts
that are classified as tracking.

Comment 1

[(no longer active)]

Attachment: Ensure that the dom.min_tracking_timeout_value pref takes effect

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8829020 [details] [diff] [review]
Ensure that the dom.min_tracking_timeout_value pref takes effect

Review of attachment 8829020 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, I think I pointed this out in one of my reviews previously.  I asked you to merge this conditional with DOMMinTimeoutValue() to create a ComputeTimeoutValue() that could be used everywhere.  Having the conditional outside the value computation is hard to maintain.

You can do that as a follow-up, though.

Comment 3

[(no longer active)]

(In reply to Ben Kelly [:bkelly] from comment #2)
> Hmm, I think I pointed this out in one of my reviews previously.  I asked
> you to merge this conditional with DOMMinTimeoutValue() to create a
> ComputeTimeoutValue() that could be used everywhere.  Having the conditional
> outside the value computation is hard to maintain.

Yes, but that patch was never landed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d812c36629
Ensure that the dom.min_tracking_timeout_value pref takes effect; r=bkelly

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b9d812c36629