1332782 - [intl.css-RTL] set base direction to RTL

Status: RESOLVED INCOMPLETE

(Core :: Internationalization: Localization, defect, P5)

Description

[Tomer Cohen :tomer]

The intl.css in ar/fa/he has code to set root direction of XUL windows. 

> window,prefwindow,dialog,wizard,page,menu { direction: rtl; }

It might be safe to remove since there is a similar rule in xul-minimal.css

> :root:-moz-locale-dir(rtl) { direction: rtl; }

https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/content/minimal-xul.css#37-39

I can confirm it is being overridden in DevTools.

Comment 1

[Tomer Cohen :tomer]

Attachment: [intl.css-RTL] set base direction to RTL - Removal

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8829042 [details] [diff] [review]
[intl.css-RTL] set base direction to RTL - Removal

Review of attachment 8829042 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, r=me. It'd be good to do some manual smoke testing after landing this to verify.

Comment 3

[Tomer Cohen :tomer]

Committed to aurora-l10n-he and central-l10n-he. If everything ges well, we should next expand this patch to cover ar and fa locales as well. https://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/b5114d0bd8ec

Comment 4

[Tomer Cohen :tomer]

Validation: there should be no Make UI RTL comment after the Global Settings comment on chrome://global/locale/intl.css, then - 

* browser.xul is using <window>, should be dir=rtl on chrome://browser/content/browser.xul
* languages.xul is using <prefwindow>, should be dir=rtl on chrome://browser/content/preferences/languages.xul
* SafeMode.xul is using <dialog>, should be dir=rtl on chrome://browser/content/safeMode.xul
* migration.xul is using <wizard>, should be dir=rtl on chrome://browser/content/migration/migration.xul
* preferences.xul is using <page>, should be dir=rtl on chrome://browser/content/preferences/in-content/preferences.xul

Comment 5

[Axel Hecht [:Pike]]

Tomer, what are the next steps here?

Comment 6

[Francesco Lodolo [:flod]]

Tomer, since we're dropping this bug component, I'm going to close this group of bugs as INCOMPLETE. Feel free to reopen them, if they're still actionable, and we'll figure out where to store them.