1332783 - Intermittent dom/html/test/browser_bug1108547.js | leaked 2 window(s) until shutdown [url = about:privatebrowsing]

Reporter

Description

•

6 years ago

treeherder

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=70783138&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1484933064/mozilla-inbound_yosemite_r7-debug_test-mochitest-e10s-browser-chrome-1-bm135-tests1-macosx-build389.txt.gz

Comment hidden (Intermittent Failures Robot)

34 failures in 749 pushes (0.045 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 14
* autoland: 10
* mozilla-central: 6
* try: 4

Platform breakdown:
* windows7-32-vm: 15
* osx-10-10: 13
* windows8-64: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-01-23&endday=2017-01-29&tree=all

Geoff Brown [:gbrown]

Comment 2

•

6 years ago

e10s-multi? See https://bugzilla.mozilla.org/show_bug.cgi?id=1254841#c4.

Comment hidden (Intermittent Failures Robot)

32 failures in 733 pushes (0.044 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 19
* mozilla-inbound: 5
* mozilla-central: 5
* try: 2
* graphics: 1

Platform breakdown:
* osx-10-10: 15
* windows8-64: 9
* windows7-32-vm: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-01-30&endday=2017-02-05&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 4

•

6 years ago

I suspect this is the only bug showing a lot of frequent failures.

from a recent win8-debug failure log[0], I see this:
13:59:10    ERROR - TEST-UNEXPECTED-FAIL | dom/html/test/browser_bug1108547.js | leaked 2 window(s) until shutdown [url = about:privatebrowsing]
13:59:10    ERROR - TEST-UNEXPECTED-FAIL | dom/html/test/browser_bug1108547.js | leaked 1 window(s) until shutdown [url = about:blank]
13:59:10     INFO - TEST-INFO | dom/html/test/browser_bug1108547.js | windows(s) leaked: [pid = 3236] [serial = 30], [pid = 3236] [serial = 31], [pid = 3236] [serial = 28]
13:59:10     INFO - runtests.py | Application ran for: 0:00:37.718000
13:59:10     INFO - zombiecheck | Reading PID log: c:\users\cltbld~1.t-w\appdata\local\temp\tmp_rvk9dpidlog
13:59:10     INFO - ==> process 3920 launched child process 3768 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="3920.0.771307914\1294230342" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser"  3920 "\\.\pipe\gecko-crash-server-pipe.3920" gpu)
13:59:10     INFO - ==> process 3920 launched child process 1836 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="3920.2.1735497481\1195549144" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser"  3920 "\\.\pipe\gecko-crash-server-pipe.3920" tab)
13:59:10     INFO - ==> process 3920 launched child process 3236 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="3920.11.2060452596\595408507" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser"  3920 "\\.\pipe\gecko-crash-server-pipe.3920" tab)
13:59:10     INFO - ==> process 3920 launched child process 948 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="3920.19.1518070530\1554434718" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser"  3920 "\\.\pipe\gecko-crash-server-pipe.3920" tab)
13:59:10     INFO - zombiecheck | Checking for orphan process with PID: 3768
13:59:10     INFO - zombiecheck | Checking for orphan process with PID: 1836
13:59:10     INFO - zombiecheck | Checking for orphan process with PID: 3236
13:59:10     INFO - zombiecheck | Checking for orphan process with PID: 948
13:59:10     INFO - Stopping web server
13:59:10     INFO - Stopping web socket server
13:59:10     INFO - Stopping ssltunnel
13:59:10     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
13:59:10     INFO - TEST-INFO | leakcheck | plugin process: leak threshold set at 0 bytes
13:59:10     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 10000 bytes
13:59:10     INFO - TEST-INFO | leakcheck | geckomediaplugin process: leak threshold set at 20000 bytes
13:59:10     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes
13:59:10     INFO - 
13:59:10     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 3920
13:59:10     INFO - 
13:59:10     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
13:59:10     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
13:59:10     INFO -    0 |TOTAL                                 |       25        0| 5529655        0|
13:59:10     INFO - 
13:59:10     INFO - nsTraceRefcnt::DumpStatistics: 1413 entries
13:59:10     INFO - 
13:59:10     INFO - TEST-PASS | leakcheck | default process: no leaks detected!
13:59:10     INFO - 
13:59:10     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, gpu process 3768
13:59:10     INFO - 
13:59:10     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
13:59:10     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
13:59:10     INFO -    0 |TOTAL                                 |       38        0|  169096        0|
13:59:10     INFO - 
13:59:10     INFO - nsTraceRefcnt::DumpStatistics: 141 entries
13:59:10     INFO - 
13:59:10     INFO - TEST-PASS | leakcheck | gpu process: no leaks detected!
13:59:10     INFO - 
13:59:10     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 1836
13:59:10     INFO - 
13:59:10     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
13:59:10     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
13:59:10     INFO -    0 |TOTAL                                 |       47        0|   66457        0|
13:59:10     INFO - 
13:59:10     INFO - nsTraceRefcnt::DumpStatistics: 726 entries
13:59:10     INFO - 
13:59:10     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
13:59:10     INFO - 
13:59:10     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 3236
13:59:10     INFO - 
13:59:10     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
13:59:10     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
13:59:10     INFO -    0 |TOTAL                                 |       33        0|  516739        0|
13:59:10     INFO - 
13:59:10     INFO - nsTraceRefcnt::DumpStatistics: 861 entries
13:59:10     INFO - 
13:59:10     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
13:59:10     INFO - 
13:59:10     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 948
13:59:10     INFO - 
13:59:10     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
13:59:10     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
13:59:10     INFO -    0 |TOTAL                                 |       32        0|  507405        0|
13:59:10     INFO - 
13:59:10     INFO - nsTraceRefcnt::DumpStatistics: 842 entries
13:59:10     INFO - 
13:59:10     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!


:ehsan, I see you are the author and main contributor to this test case, is there a chance you could work on this in the next 2 weeks?  Do ask for more information if you need any.


[0] https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64-debug/1486323548/autoland_win8_64-debug_test-mochitest-e10s-browser-chrome-2-bm127-tests1-windows-build96.txt.gz

Flags: needinfo?(ehsan)

(no longer active)

Comment 5

•

6 years ago

Sorry but I don't really have any time to spend on this.  Andrew, can you please find another victim?

FWIW I took a quick look at the test and I suspect the leak is caused by the testBrowser and privateWin variables being captured for the closures here and never nulled out, so nulling both of them at the end of runPass *should* fix the leak, I think.

Flags: needinfo?(ehsan) → needinfo?(overholt)

Andrew Overholt [:overholt]

Comment 6

•

6 years ago

Michael told me he was bored ;)

Flags: needinfo?(overholt) → needinfo?(michael)

Comment hidden (Intermittent Failures Robot)

59 failures in 836 pushes (0.071 failures/push) were associated with this bug in the last 7 days. 

This is the #33 most frequent failure this week. 

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:
* mozilla-inbound: 34
* autoland: 18
* try: 6
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 27
* windows8-64: 17
* windows7-32-vm: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-02-06&endday=2017-02-12&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 8

•

6 years ago

checking in here, we had 59 failures last week, that is a lot which tells me we can reproduce this.  Let me know if we can get this fixed this week, otherwise I would recommend disabling this test until we have more time to focus on this.

Comment hidden (Intermittent Failures Robot)

27 failures in 833 pushes (0.032 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 10
* autoland: 9
* mozilla-central: 5
* try: 2
* graphics: 1

Platform breakdown:
* osx-10-10: 12
* windows8-64: 7
* windows7-32-vm: 7
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-02-13&endday=2017-02-19&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 10

•

6 years ago

any updates here Michael?

Comment hidden (Intermittent Failures Robot)

22 failures in 812 pushes (0.027 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 7
* mozilla-inbound: 6
* mozilla-central: 6
* try: 2
* graphics: 1

Platform breakdown:
* windows8-64: 10
* windows7-32-vm: 9
* osx-10-10: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-02-20&endday=2017-02-26&tree=all

(no longer active)

Comment 12

•

6 years ago

(In reply to :Ehsan Akhgari from comment #5)
> FWIW I took a quick look at the test and I suspect the leak is caused by the
> testBrowser and privateWin variables being captured for the closures here
> and never nulled out, so nulling both of them at the end of runPass *should*
> fix the leak, I think.

Anyone should be able to push this to try and test...

Nika Layzell [:nika] (ni? for response)

Comment 13

•

6 years ago

Oops.

IIRC I did this ages ago, as part of another push I was doing to try for other reasons. I then forgot about it (oops). I just went back and retriggered Windows 8_x64 M-e10s(bc2) a bunch of times (the one time it had already run was green), we'll see how it looks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d75f8c9e9fa7d7f62677e738867977367cc4bfd4&selectedJob=77241879

Flags: needinfo?(michael)

Geoff Brown [:gbrown]

Comment 14

•

6 years ago

I pushed https://treeherder.mozilla.org/#/jobs?repo=try&revision=dede542e1bd9d5825f0ec13d913be39e9c0d7a6b to give us results against a current revision. All was well until infra issues hit.

Pulsebot

Comment 15

•

6 years ago

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/053c34ac7631
Null out privateWin and testBrowser, r=ehsan

Ryan VanderMeulen [:RyanVM]

Comment 16

•

6 years ago

bugherderuplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/2849745ef5cd

status-firefox53: --- → fixed

Geoff Brown [:gbrown]

Updated

•

6 years ago

Whiteboard: [stockwell fixed]

Ryan VanderMeulen [:RyanVM]

Comment 17

•

6 years ago

bugherderuplift

https://hg.mozilla.org/releases/mozilla-beta/rev/28eb6ec7d303

status-firefox52: --- → fixed

Flags: in-testsuite+

Whiteboard: [stockwell fixed]

Ryan VanderMeulen [:RyanVM]

Comment 18

•

6 years ago

bugherderuplift

https://hg.mozilla.org/releases/mozilla-release/rev/28eb6ec7d303

Ryan VanderMeulen [:RyanVM]

Comment 19

•

6 years ago

bugherderuplift

https://hg.mozilla.org/releases/mozilla-esr52/rev/28eb6ec7d303

status-firefox-esr52: --- → fixed

Carsten Book [:Tomcat]

Comment 20

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/053c34ac7631

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox54: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla54

Joel Maher ( :jmaher ) (UTC -8)

Comment 21

•

6 years ago

:RyanVM, why did you remove [stockwell fixed] whiteboard tag?

Flags: needinfo?(ryanvm)

Ryan VanderMeulen [:RyanVM]

Comment 22

•

6 years ago

I don't know how that happened :)

Flags: needinfo?(ryanvm)

Whiteboard: [stockwell fixed]

(no longer active)

Comment 23

•

6 years ago

(In reply to Geoff Brown [:gbrown] from comment #14)
> I pushed
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=dede542e1bd9d5825f0ec13d913be39e9c0d7a6b to give us
> results against a current revision. All was well until infra issues hit.

Thank you Geoff!

Comment hidden (Intermittent Failures Robot)

13 failures in 783 pushes (0.017 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 8
* mozilla-inbound: 2
* mozilla-central: 2
* try: 1

Platform breakdown:
* osx-10-10: 5
* windows8-64: 4
* windows7-32-vm: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332783&startday=2017-02-27&endday=2017-03-05&tree=all

Nobody; OK to take it and work on it

Assignee

Updated

•

4 years ago

Component: DOM → DOM: Core & HTML