Closed Bug 1332812 Opened 8 years ago Closed 8 years ago

Remove some more nsIDOMElement bits

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected
firefox54 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

There's more there that's unused or nearly unused.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8829072 [details] [diff] [review] Remove some more unused or nearly-unused nsIDOMElement bits Review of attachment 8829072 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! ::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp @@ -713,5 @@ > } else { > NS_ADDREF(*aNodeOut = aNodeIn); > } > - nsCOMPtr<nsIDOMHTMLElement> element(do_QueryInterface(*aNodeOut)); > - if (element) { Did you mean to remove this code as part of this patch? I can believe this is dead code (all elements are namespaced nowadays, perhaps?), but I'm unclear as to how it relates to the removal here, since we're not removing, say, the namespaceURI getter.
Attachment #8829072 - Flags: review?(nfroyd) → review+
> Did you mean to remove this code as part of this patch? Yes, I did. > all elements are namespaced nowadays, perhaps? Well, all HTML elements are. And the parser hasn't output "_base_href" bits in years. > since we're not removing, say, the namespaceURI getter No, but we're removing nsIDOMElement::RemoveAttribute. I could have ported this code to the webidl RemoveAttribute signature instead, but since it was dead code anyway...
Depends on: 835981
No longer depends on: 1332704
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c724fbd9c326 Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
Argh. I thought I had done an all-platforms build run of this on try. :(
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d972f1002840 Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: