Remove some more nsIDOMElement bits

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox53 affected, firefox54 fixed)

Details

Attachments

(1 attachment)

There's more there that's unused or nearly unused.
(Assignee)

Comment 1

2 years ago
Created attachment 8829072 [details] [diff] [review]
Remove some more unused or nearly-unused nsIDOMElement bits
Attachment #8829072 - Flags: review?(nfroyd)
(Assignee)

Updated

2 years ago
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8829072 [details] [diff] [review]
Remove some more unused or nearly-unused nsIDOMElement bits

Review of attachment 8829072 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
@@ -713,5 @@
>      } else {
>          NS_ADDREF(*aNodeOut = aNodeIn);
>      }
> -    nsCOMPtr<nsIDOMHTMLElement> element(do_QueryInterface(*aNodeOut));
> -    if (element) {

Did you mean to remove this code as part of this patch?  I can believe this is dead code (all elements are namespaced nowadays, perhaps?), but I'm unclear as to how it relates to the removal here, since we're not removing, say, the namespaceURI getter.
Attachment #8829072 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

2 years ago
> Did you mean to remove this code as part of this patch?

Yes, I did.

> all elements are namespaced nowadays, perhaps?

Well, all HTML elements are.  And the parser hasn't output "_base_href" bits in years.

> since we're not removing, say, the namespaceURI getter

No, but we're removing nsIDOMElement::RemoveAttribute.  I could have ported this code to the webidl RemoveAttribute signature instead, but since it was dead code anyway...
(Assignee)

Updated

2 years ago
Depends on: 835981
No longer depends on: 1332704

Comment 4

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c724fbd9c326
Remove some more unused or nearly-unused nsIDOMElement bits.  r=froydnj
(Assignee)

Comment 6

2 years ago
Argh.  I thought I had done an all-platforms build run of this on try.  :(
Flags: needinfo?(bzbarsky)

Comment 7

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d972f1002840
Remove some more unused or nearly-unused nsIDOMElement bits.  r=froydnj

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d972f1002840
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.