Closed
Bug 1332812
Opened 8 years ago
Closed 8 years ago
Remove some more nsIDOMElement bits
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
30.93 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
There's more there that's unused or nearly unused.
![]() |
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8829072 -
Flags: review?(nfroyd)
![]() |
Assignee | |
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 8829072 [details] [diff] [review]
Remove some more unused or nearly-unused nsIDOMElement bits
Review of attachment 8829072 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you!
::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
@@ -713,5 @@
> } else {
> NS_ADDREF(*aNodeOut = aNodeIn);
> }
> - nsCOMPtr<nsIDOMHTMLElement> element(do_QueryInterface(*aNodeOut));
> - if (element) {
Did you mean to remove this code as part of this patch? I can believe this is dead code (all elements are namespaced nowadays, perhaps?), but I'm unclear as to how it relates to the removal here, since we're not removing, say, the namespaceURI getter.
Attachment #8829072 -
Flags: review?(nfroyd) → review+
![]() |
Assignee | |
Comment 3•8 years ago
|
||
> Did you mean to remove this code as part of this patch?
Yes, I did.
> all elements are namespaced nowadays, perhaps?
Well, all HTML elements are. And the parser hasn't output "_base_href" bits in years.
> since we're not removing, say, the namespaceURI getter
No, but we're removing nsIDOMElement::RemoveAttribute. I could have ported this code to the webidl RemoveAttribute signature instead, but since it was dead code anyway...
![]() |
Assignee | |
Updated•8 years ago
|
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c724fbd9c326
Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
![]() |
||
Comment 5•8 years ago
|
||
Backed out for build bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/12ae47283fc97ccfe5af32d6e6cca88e44ae901a
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c724fbd9c3267c33a322463dca779bbb8c3ec6e9
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=73938035&repo=mozilla-inbound
> accessible/windows/sdn/sdnAccessible.cpp(184): error C2039: 'GetAttributeNS': is not a member of 'nsIDOMElement'
Flags: needinfo?(bzbarsky)
![]() |
Assignee | |
Comment 6•8 years ago
|
||
Argh. I thought I had done an all-platforms build run of this on try. :(
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d972f1002840
Remove some more unused or nearly-unused nsIDOMElement bits. r=froydnj
Comment 8•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•