Closed Bug 1332827 Opened 4 years ago Closed 4 years ago

Port bug 1330533 to TB [Simplify the LibFuzzer setup in Gecko]

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 53.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

In m-c they changed the LibFuzzer in nsBrowserApp.cpp. Not sure if we use this as the builds complete without the changes. But when we rely on this, future changes could break us and then it would be harder to find the cause.
Attached patch LibFuzz.patchSplinter Review
Jörg, to check the patch you can use your before/after diff magic to be sure I found all changes. ;-)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8829090 - Flags: review?(jorgk)
Comment on attachment 8829090 [details] [diff] [review]
LibFuzz.patch

Review of attachment 8829090 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Richard Marti (:Paenglab) from comment #1)
> Jörg, to check the patch you can use your before/after diff magic to be sure
> I found all changes. ;-)
I'm afraid that was indeed necessary since the M-C bug had four changesets and three of them edited the same file nsBrowserApp.cpp.

Are you sure that the change to moz.build is correct? Check the file, there is for example:
LOCAL_INCLUDES += [
    '!/build',
    '/mozilla/toolkit/xre',

r+ with this fixed.

::: mail/app/moz.build
@@ +17,5 @@
>  
>  if CONFIG['LIBFUZZER']:
> +    USE_LIBS += [ 'fuzzer' ]
> +    LOCAL_INCLUDES += [
> +        '/tools/fuzzing/libfuzzer',

I think you need /mozilla/tools/ ...
Attachment #8829090 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8829090 [details] [diff] [review]
> LibFuzz.patch
> 
> Review of attachment 8829090 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Richard Marti (:Paenglab) from comment #1)
> > Jörg, to check the patch you can use your before/after diff magic to be sure
> > I found all changes. ;-)
> I'm afraid that was indeed necessary since the M-C bug had four changesets
> and three of them edited the same file nsBrowserApp.cpp.
> 
> Are you sure that the change to moz.build is correct? Check the file, there
> is for example:
> LOCAL_INCLUDES += [
>     '!/build',
>     '/mozilla/toolkit/xre',
> 
> r+ with this fixed.
> 
> ::: mail/app/moz.build
> @@ +17,5 @@
> >  
> >  if CONFIG['LIBFUZZER']:
> > +    USE_LIBS += [ 'fuzzer' ]
> > +    LOCAL_INCLUDES += [
> > +        '/tools/fuzzing/libfuzzer',
> 
> I think you need /mozilla/tools/ ...

Correct, good we have reviews. :-) Fixed. I'll land this after the next m-c push.
https://hg.mozilla.org/comm-central/rev/a8a8f8a2b5cd637882b14f0f298f0724d5d15616
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.