1332833 - [intl.css-RTL] removal of dir=ltr from file and url paths

Status: RESOLVED INCOMPLETE

(Core :: Internationalization: Localization, defect, P5)

Description

[Tomer Cohen :tomer]

In order to eliminate intl.css hacks, I'd suggest to remove the dir=rtl hack from the intl.css of affected locales. These rules should live in the equivalent stylesheet of each of these screens and triggered using the :-moz-locale-dir(rtl) selector.

>    /* set LTR for url and file paths and align them to the right - Bug 289934  */
>    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
>      direction: ltr !important;
>      text-align: right !important;
>    }

Comment 1

[Tomer Cohen :tomer]

(In reply to Tomer Cohen :tomer from comment #0)
> >    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
#downloadFolder is declared on main.xul. Its removal from intl.css is required to simplify the fix for bug 1217907

https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/browser/components/preferences/in-content/main.xul#244

Comment 2

[Tomer Cohen :tomer]

> >    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
#urltext is on pageInfo.xul
https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/browser/base/content/pageinfo/pageInfo.xul#106


> >    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
#source is a very generic identifier, but I think it is unknownContentType.xul, which is the file open dialog.

https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/toolkit/mozapps/downloads/content/unknownContentType.xul#50

https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd

Comment 3

[Tomer Cohen :tomer]

> >    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
#url is risky as well, but I've found it only on preferences/permissions.xul.

https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/browser/components/preferences/permissions.xul#37 

> >    #source, #path, #url, #feedurl, #downloadFolder, #urltext {
#path is common, but I think it is preferences/cookies.xul.

https://dxr.mozilla.org/mozilla-central/rev/3cedab21a7e65e6a1c4c2294ecfb5502575a46e3/browser/components/preferences/cookies.xul#79