1332844 - Taskcluster Linux32 tests not being scheduled on Try

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Ryan VanderMeulen [:RyanVM]]

I did a push to Try with a syntax that should have run jobs on both Linux32 and Linux64, but only Linux64 tests started.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fa915e0ae7735ac98ff674e0609a9e1e1cfaf32

Which means that AFAICT, we have no way of scheduling Linux32 tests on Try at the moment. Which means that they aren't Tier 1.

Comment 1

[Geoff Brown [:gbrown]]

I've been using '-p linux', consistent with trychooser.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

My syntax came directly from Trychooser. That's the result you get when you check Linux32/Linux64/Android from the list of platforms to run tests on.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

So, Ubuntu translates to linux, linux64, linux64-asan

But the test platform name is linux32.  Just picking a random linux32 test task from full-task-graph.json:

  "test-linux32/debug-cppunit": {
    "attributes": {
      "build_platform": "linux",
      "build_type": "debug",
      "e10s": false,
      "kind": "test",
      "run_on_projects": [
        "all"
      ],
      "test_chunk": "1",
      "test_platform": "linux32",
      "unittest_flavor": "cppunittest",
      "unittest_suite": "cppunittest",
      "unittest_try_name": "cppunit"
    },
    "dependencies": {
      "build": "build-linux/debug",
      "docker-image": "build-docker-image-desktop-test"
    },

which makes sense, since test-platforms.yml says

linux32/debug:
    build-platform: linux/debug
    test-sets:
        - linux32-tests

so, I think we need to change the "Ubuntu" alias to refer to linux32, rather than linux.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1332844: allow printing Options when notifications is None;

(I stumbled over this while debugging)

Review commit: https://reviewboard.mozilla.org/r/106306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106306/

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1332844: alias "Ubuntu" to test platform linux32, rather than linux;

Review commit: https://reviewboard.mozilla.org/r/106308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106308/

Comment 6

[Geoff Brown [:gbrown]]

Comment on attachment 8829149 [details]
Bug 1332844: allow printing Options when notifications is None;

https://reviewboard.mozilla.org/r/106306/#review107492

Comment 7

[Geoff Brown [:gbrown]]

Comment on attachment 8829150 [details]
Bug 1332844: alias "Ubuntu" to test platform linux32, rather than linux;

https://reviewboard.mozilla.org/r/106308/#review107494

Comment 8

[Geoff Brown [:gbrown]]

Thanks Dustin.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc8c2f345bbb
allow printing Options when notifications is None; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/1306d84ed02f
alias "Ubuntu" to test platform linux32, rather than linux; r=gbrown

Comment 10

[Ryan VanderMeulen [:RyanVM]]

ni? myself to uplift this to Aurora53 as well.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for taskgraph failure on request on developer:

https://hg.mozilla.org/integration/autoland/rev/1071baee0e980cf98bdbbc10f649bb6298fb1903
https://hg.mozilla.org/integration/autoland/rev/176ee06978a32c432a6378543810a99a57dc5794

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1306d84ed02f2f86311df19431ed33ba949f1980
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=71201714&repo=autoland
> TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py:8:1 | 'itertools' imported but unused (F401)

TEST-UNEXPECTED-FAIL | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_u_platforms_negated_pretty, line 221: Lists differ: [{u'test': u'gtest', u'platfor... != [{u'test': u'gtest', u'platfor...
AssertionError: Lists differ: [{u'test': u'gtest', u'platfor... != [{u'test': u'gtest', u'platfor...
TEST-UNEXPECTED-FAIL | /home/worker/checkouts/gecko/taskcluster/taskgraph/test/test_try_option_syntax.py | TestTryOptionSyntax.test_u_platforms_pretty, line 207: Lists differ: [{u'test': u'gtest', u'platfor... != [{u'test': u'gtest', u'platfor...
AssertionError: Lists differ: [{u'test': u'gtest', u'platfor... != [{u'test': u'gtest', u'platfor...

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8829149 [details]
Bug 1332844: allow printing Options when notifications is None;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106306/diff/1-2/

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8829150 [details]
Bug 1332844: alias "Ubuntu" to test platform linux32, rather than linux;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106308/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7c3b204b2d7
allow printing Options when notifications is None; r=gbrown
https://hg.mozilla.org/integration/autoland/rev/b6f679c08c78
alias "Ubuntu" to test platform linux32, rather than linux; r=gbrown

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

No more info needed.

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f7c3b204b2d7
https://hg.mozilla.org/mozilla-central/rev/b6f679c08c78

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bb6edc872722
https://hg.mozilla.org/releases/mozilla-aurora/rev/1aadf4d5fd3c