Bug 1332897 - Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`.
59 bytes, text/x-review-board-request
STR: 1. Sign in to Sync with a new or existing Firefox Account on Windows desktop 2. Add a bookmark 3. Set the bookmark's keyword and trigger a sync 4. Sign in to Sync on a Linux desktop 5. Trigger a sync and verify the bookmark is synced to the Fx account on Linux desktop with the same keyword. 6. Change the keyword of same bookmark on Linux desktop and trigger a sync 7. Go to Windows desktop, trigger a sync on the Fx account and verify bookmark keyword has changed Expected: Bookmarks keyword changes should be bidirectional, change on one device should be synced on the other device. Actual: Keyword change on Windows doesn't sync to Linux but if I change (add, delete)keyword on Linux it syncs correctly to Windows Note: Between Mac and Linux, keyword changes on Mac sync to Linux but keyword change on Linux didn't sync back to Mac OS.
I suspect this is bug 1328737 (although that describes the problem as being that we don't remove keywords correctly, and as a keyword can only apply to one URL, sometimes changing a keyword from one URL to another doesn't work)
See Also: → bug 1328737
This does sound a lot like bug 1328737. Keywords are funky: they're linked to URLs, but we sync them for individual bookmarks. Flagging myself to check if this still happens after bug 1328737 lands.
I'm so sorry, I should've caught this in review for bug 1328737. Added a test just in case.
Assignee: nobody → kit
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8833016 [details] Bug 1332897 - Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`. https://reviewboard.mozilla.org/r/109250/#review110382 Ah, crap. and yeah, it looks like that function would be silent when just passed one arg, my bad.
Attachment #8833016 - Flags: review?(tchiovoloni) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3574f541a92e Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`. r=tcsc
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I have verified this bug fix on the latest nightly and found it to be working fine.
status-firefox54: fixed → verified
You need to log in before you can comment on or make changes to this bug.