1332897 - Keyword doesn't sync across all platforms, it is one directional in some cases

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Kanchan Kumari QA]

STR:
1. Sign in to Sync with a new or existing Firefox Account on Windows desktop
2. Add a bookmark
3. Set the bookmark's keyword and trigger a sync
4. Sign in to Sync on a Linux desktop
5. Trigger a sync and verify the bookmark is synced to the Fx account on Linux desktop with the same keyword. 
6. Change the keyword of same bookmark on Linux desktop and trigger a sync
7. Go to Windows desktop, trigger a sync on the Fx account and verify bookmark keyword has changed 

Expected: Bookmarks keyword changes should be bidirectional, change on one device should be synced on the other device.

Actual: Keyword change on Windows doesn't sync to Linux but if I change (add, delete)keyword on Linux it syncs correctly to Windows

Note: Between Mac and Linux, keyword changes on Mac sync to Linux but keyword change on Linux didn't sync back to Mac OS.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I suspect this is bug 1328737 (although that describes the problem as being that we don't remove keywords correctly, and as a keyword can only apply to one URL, sometimes changing a keyword from one URL to another doesn't work)

Comment 2

[Lina Butler [:lina]]

This does sound a lot like bug 1328737. Keywords are funky: they're linked to URLs, but we sync them for individual bookmarks. Flagging myself to check if this still happens after bug 1328737 lands.

Comment 3

[Lina Butler [:lina]]

Attachment: Bug 1332897 - Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`.

Review commit: https://reviewboard.mozilla.org/r/109250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109250/

Comment 4

[Lina Butler [:lina]]

I'm so sorry, I should've caught this in review for bug 1328737. Added a test just in case.

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8833016 [details]
Bug 1332897 - Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`.

https://reviewboard.mozilla.org/r/109250/#review110382

Ah, ****. and yeah, it looks like that function would be silent when just passed one arg, my bad.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3574f541a92e
Ensure `removeConflictingKeywords` passes the correct params to `addSyncChangesForBookmarksWithURL`. r=tcsc

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3574f541a92e

Comment 8

[Kanchan Kumari QA]

I have verified this bug fix on the latest nightly and found it to be working fine.