gl test test_capture.html has an ASAN leak while running on ubuntu 16.04

RESOLVED WORKSFORME

Status

()

Core
Layout
RESOLVED WORKSFORME
9 months ago
8 months ago

People

(Reporter: jmaher, Assigned: padenot)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 months ago
While porting tests from Ubuntu 12.04 to Ubuntu 16.04, we have found a few problems- in this case mochitest-gl has a perma leak on linux64-asan.

After narrowing down the leak, I have found that test_capture.html is the culprit:
https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/webgl-mochitest/test_capture.html

According to bug 1319801 comment 13, we have an issue with cubeb_destroy().

I had intended to ignore this leak via whitelist, but it became quite difficult to do, so for the time being this specific test will no be run on ASAN builds.

here is an example of the raw failure log:
https://public-artifacts.taskcluster.net/BfGWGhsiTfeRJ90-TcQFfg/0/public/logs/live_backing.log
(Reporter)

Comment 1

9 months ago
in addition, it looks like dom/canvas/test/crossorigin/test_video_crossorigin.html also has the same failure:
https://queue.taskcluster.net/v1/task/dXtNZTjyRXaFp_NnWiCFzw/runs/0/artifacts/public/logs/live_backing.log
(Reporter)

Updated

9 months ago
Blocks: 1333113
(Assignee)

Comment 2

9 months ago
Taking this bug. Since this is task cluster, it should be easy to ssh in and debug. I faced a task cluster bug trying to do so, but I'll pick it up when it's solved.
Assignee: nobody → padenot
Depends on: 1333380
Flags: needinfo?(jmaher)
(Reporter)

Comment 3

9 months ago
thanks for picking this up :padenot.  bummer you found a problem getting into a box, I see there is good information in the bug and that should help us get to a fix faster.

Do let me know if I can help out in the meantime.
Flags: needinfo?(jmaher)
(Assignee)

Comment 4

9 months ago
I solved the first issue (or side-stepped it rather). I'm now facing bug 1333813, that prevents me attaching a debugger to the child process to debug this further.

When it's fixed, I'll pick this up again: I can't repro locally unfortunately.
Depends on: 1333813
(Assignee)

Updated

9 months ago
Depends on: 1334132
(Assignee)

Comment 5

9 months ago
I worked my way around comment 4 with a patch, now pushed to try with the same setup:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=236e8270bea499f9eb3c93b5ee69afc2b4ffe47f
(Reporter)

Comment 6

9 months ago
either this is fixed intentionally or accidentally- no more leak!
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED

Updated

8 months ago
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.