Closed
Bug 1332930
Opened 8 years ago
Closed 8 years ago
Shutting off buildbot nighties shut off periodicupdates
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox-esr45 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53+ fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | + | fixed |
People
(Reporter: philor, Assigned: kmoir)
References
Details
(Keywords: regression)
Attachments
(3 files, 3 obsolete files)
1.73 KB,
patch
|
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
1.09 KB,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
1.46 KB,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
As attachment 8827707 [details] says, shutting off buildbot nightlies also shut off the periodicupdate builder. Since the expiration on the last update that landed is April 26th, and 53 doesn't get replaced until June 13th, and we only do HPKP updates on aurora, not on beta/release, we have six weeks to get updates going on aurora.
Reporter | ||
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]:
If we don't fix it (or manually land an update to the expiration), HPKP will be broken two weeks into the 53 release lifespan.
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
status-firefox53:
--- → affected
status-firefox-esr45:
--- → unaffected
tracking-firefox53:
--- → ?
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → kmoir
Assignee | ||
Comment 3•8 years ago
|
||
So renabling them in buildbot is problematic because I haven't found a way to enable the periodic builds without renabling the nightly ones as well. I think I'm going to enable them in tc via the new work for cron jobs in bug 1252948.
Assignee | ||
Comment 4•8 years ago
|
||
wip buildbot patch
Fixing this is very difficult because the way the build dependencies work. I can't seem to leave the file update builder there while removing the generic builder
Assignee | ||
Comment 5•8 years ago
|
||
(build6)[kmoir@dev-master2.bb.releng.use1.mozilla.com build6]$ diff old new
72a73,74
> Linux x86-64 mozilla-central build SigningScriptFactory
> Linux x86-64 mozilla-central periodic file update ScriptFactory
120a123,124
> Linux x86-64 mozilla-aurora build SigningScriptFactory
> Linux x86-64 mozilla-aurora periodic file update ScriptFactory
still need to remove the build SigningScriptFactory for the branches
Comment 6•8 years ago
|
||
I tried taking a look, but
* I was unsuccessful in getting a buildbot env installed on my mac laptop, then
* I tried creating a buildbot centos docker image https://github.com/escapewindow/bbdocker but am currently stymied by pycrypto and pyOpenSSL not finding -lpython2.7 .
Rather than sink more hours into shaving the yak of reproducing the buildbot builder lists, I'm going to hazard a guess you're going to need one of these ugly |if| blocks to delete the generic builder: https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py#l2698
Assignee | ||
Comment 7•8 years ago
|
||
Thanks Aki, I will take another look
Assignee | ||
Updated•8 years ago
|
Attachment #8830065 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Attachment #8830066 -
Attachment is obsolete: true
Assignee | ||
Comment 8•8 years ago
|
||
builder diff
72a73
> Linux x86-64 mozilla-central periodic file update ScriptFactory
120a122
> Linux x86-64 mozilla-aurora periodic file update ScriptFactory
Assignee | ||
Updated•8 years ago
|
Attachment #8830772 -
Flags: review?(aki)
Comment 9•8 years ago
|
||
Comment on attachment 8830772 [details] [diff] [review]
bug1332930.patch
Blame/annotate will show people why this block is here, but it might be nice to add a comment to the |else:| block to say this is to keep periodicupdates.
Good work, thanks! These if blocks aren't pretty, but they're part of moving off buildbot. At some point we'll be able to get rid of these config files altogether.
Attachment #8830772 -
Flags: review?(aki) → review+
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8830772 -
Attachment is obsolete: true
Assignee | ||
Comment 11•8 years ago
|
||
landed and merged to production, tests pass
Attachment #8830838 -
Flags: checked-in+
Assignee | ||
Comment 12•8 years ago
|
||
verified the builder exists here
http://buildbot-master70.bb.releng.use1.mozilla.com:8001/builders
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•8 years ago
|
||
Either we were astonishingly unlucky, getting a bad URL from the taskcluster index for the lastest build on both mozilla-central and mozilla-aurora, or the change to TC builds also broke that part of periodicupdates, since both runs this morning failed by getting a 404 URL for the builds.
Comment 15•8 years ago
|
||
Whomever is around first gets to review :)
We're not finding the artifacts because they're not pretty named: https://tools.taskcluster.net/task-inspector/#S_1gifVoSVyRo8JXHmyfuA/0
I'm guessing this patch will fix, but I'm not 100% sure.
Attachment #8831313 -
Flags: review?(nthomas)
Attachment #8831313 -
Flags: review?(kmoir)
Attachment #8831313 -
Flags: review?(coop)
Comment 16•8 years ago
|
||
Comment on attachment 8831313 [details] [diff] [review]
fix_periodic.diff
lgtm
Attachment #8831313 -
Flags: review?(nthomas) → review+
Updated•8 years ago
|
Attachment #8831313 -
Flags: review?(kmoir)
Attachment #8831313 -
Flags: review?(coop)
Comment 17•8 years ago
|
||
https://hg.mozilla.org/build/tools/rev/832aa943661555bdb4d9275a18c0232c76e279f3
bug 1332930 - use simple filenames for tc periodic updates. r=rail
Comment 18•8 years ago
|
||
Attachment #8831444 -
Flags: review?
Updated•8 years ago
|
Attachment #8831444 -
Flags: review?(rail)
Updated•8 years ago
|
Attachment #8831444 -
Flags: review?(rail) → review+
Comment 19•8 years ago
|
||
https://hg.mozilla.org/build/tools/rev/5dec772a8d528f5f76f7c17566eb5c3b2e3dd102
bug 1332930 - fix m-b m-r m-esr periodic updates. r=rail
Updated•8 years ago
|
Updated•8 years ago
|
Attachment #8831444 -
Flags: review?
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•