1332969 - stylo: several tests crash with "panicked at 'A device flush was pending'"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

To reproduce, execute:
> ./mach mochitest --disable-e10s layout/style/test/test_bug798843_pref.html

It crashes with
thread '<unnamed>' panicked at 'A device flush was pending', C:\mozilla-source\stylo\servo\components\style\gecko\data.rs:139

RUST_BACKTRACE=1 doesn't give me any further stack info.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

layout/style/test/test_bug798843_pref.html
layout/style/test/test_dont_use_document_colors.html
layout/style/test/test_moz_device_pixel_ratio.html
layout/style/test/test_pixel_lengths.html
layout/style/test/test_unprefixing_service.html
layout/style/test/test_unprefixing_service_prefs.html

Comment 2

[Bobby Holley (:bholley)]

Looks like this assertion was added recently in bug 1331213.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Well, the idea with that assertion was to catch the different places where we don't flush stuff where we should, but we don't, so it's doing its job :).

I think those are all testing prefs or media queries that should make us rebuild all style data, but we're not doing that on time.

Should be a straightforward patch, will write it when I come from class if I have the time.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Verified that this has been fixed.