1332984 - Clean up usage of nsIDOMCharacterData into editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Makoto Kato [:m_kato]]

It is unnecessary to use nsIDOMCharacterData if getting text content of text node.  So we should clean up the  usage of nsIDOMCharacterData into editor.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1332984 - Clean up usage of nsIDOMCharacterData into editor.

Some uses nsIDOMCharacterData to get the attribute of text node.  But, by using Text object, we don't need nsIDOMCharacter.  So we should use Text object instead of nsIDOMCharacterData instead if possible.

Review commit: https://reviewboard.mozilla.org/r/106436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106436/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8829319 [details]
Bug 1332984 - Clean up usage of nsIDOMCharacterData into editor.

https://reviewboard.mozilla.org/r/106436/#review107742

::: editor/libeditor/TextEditor.cpp:504
(Diff revision 1)
>    }
>  
> -  *outBRNode = brNode;
> +  *outBRNode = GetAsDOMNode(brNode);
>    if (*outBRNode && (aSelect != eNone)) {
>      int32_t offset;
> -    nsCOMPtr<nsIDOMNode> parent = GetNodeLocation(*outBRNode, &offset);
> +    nsCOMPtr<nsINode> parent = GetNodeLocation(brNode, &offset);

Although, not a scope of this bug, I wonder, GetNodeLocation() can use EditorDOMPoint as its result.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d8d5b5d1aa6
Clean up usage of nsIDOMCharacterData into editor. r=masayuki

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d8d5b5d1aa6