Closed Bug 1332992 Opened 8 years ago Closed 8 years ago

304 responses include a content-type header.

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: markh, Unassigned)

Details

A conditional request to https://profile.accounts.firefox.com/v1/profile returns a 304 with "Content-Type: application/json; charset=utf-8" but an empty body. This causes devtools to apparently get a little upset trying to parse the empty payload as JSON (saying it is invalid). If you squint a little, you could take https://tools.ietf.org/html/rfc7232#section-4.1 as saying this header SHOULD NOT be included. Probably not a big deal and possibly could be argued it's more a devtools bug, but I can't see a reason the header should be included, so opened this bug. Your welcome ;)
(In reply to Mark Hammond [:markh] from comment #0) > Your welcome ;) "Your" also welcome for the appalling grammar :)
I looked at the profile-server source and we don't have any special handling for 304 empty payload responses. I guess it is the default hapi behaviour. Probably something that devtools should fix, one of the related bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=859138#c21
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.